You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@taverna.apache.org by alaninmcr <al...@googlemail.com> on 2015/07/28 15:48:54 UTC
Removal of hibernate dependency
Hello everybody,
I have removed the hibernate dependency from taverna-reference-impl.
There may be cascade effects that will need to be fixed as well.
Alan
Re: Removal of hibernate dependency
Posted by Ian Dunlop <ia...@manchester.ac.uk>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hello,
Should hibernate be removed from parent pom before I start the release
process. I don't want it to be rejected because of this.
Cheers,
Ian
On 29/07/2015 09:52, Alan Williams wrote:
> On 29-Jul-15 08:29, Christian Brenninkmeijer wrote:
>> If the goal is to remove hibrate, the best approach is to comment
>> out hibernate from the parent pom with a message that is no loner
>> supported.
>
> Yes. It is probably a good idea to remove the hibernate stuff from
> the parent pom. However, some modules can import with an explicit
> version :(
>
>> That way code that still uses hibrate will NOT build and no one
>> will accidentally put it back.
>
> No. It will still build _with_ an explicit version. That's why I
> started at the reference impl and removed the hibernate variants of
> the classes. If any code is weird enough to reference those classes
> then it will break.
>
> We'll also need to any application contexts that talk about the
> database version.
>
>> Christian
>
> Alan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJVuJsGAAoJEPK45GBX+Cy5lqYIAKMwrVohgEU8+BcR1BZ+bblh
9SlMAiJV6j5eyi44Hbc1Sz9Psbyz0RtqvlEQG1yMBCUUfI5Si1BOnRbbjoWAtpJZ
/JFyrecbam8pwHdWoW0SYcuE4WnMz0HOymfIDPwvENtfLFYwTJHl4LhHTpredO2e
roQMngjZHUbZIB4/tosnFpriVgD3/YvyiyixkFnmQ5fmb1upg2OgmMHZHLcysg8J
sBVsa8k3yNryTFmDNqfl2gO6WS9V7wBWBpyNYGHzARlHsiqahyj58Z9rEALL0yjE
b/sZHD1zQEHOX0J9uwpWM9afI4bCyOAYvALxfHogUhKWwGDF239ojZ0J0J9/vvI=
=5vE2
-----END PGP SIGNATURE-----
Re: Removal of hibernate dependency
Posted by Alan Williams <al...@googlemail.com>.
On 29-Jul-15 08:29, Christian Brenninkmeijer wrote:
> If the goal is to remove hibrate, the best approach is to comment out hibernate from the parent pom with a message that is no loner supported.
Yes. It is probably a good idea to remove the hibernate stuff from the
parent pom. However, some modules can import with an explicit version :(
> That way code that still uses hibrate will NOT build and no one will accidentally put it back.
No. It will still build _with_ an explicit version. That's why I started
at the reference impl and removed the hibernate variants of the classes.
If any code is weird enough to reference those classes then it will break.
We'll also need to any application contexts that talk about the database
version.
> Christian
Alan
RE: Removal of hibernate dependency
Posted by Christian Brenninkmeijer <ch...@manchester.ac.uk>.
If the goal is to remove hibrate, the best approach is to comment out hibernate from the parent pom with a message that is no loner supported.
That way code that still uses hibrate will NOT build and no one will accidentally put it back.
Christian
________________________________________
From: Alan Williams [alaninmcr@googlemail.com]
Sent: Tuesday, July 28, 2015 6:03 PM
To: dev@taverna.incubator.apache.org
Subject: Re: Removal of hibernate dependency
On 28-Jul-15 15:29, Ian Dunlop wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Hello,
>
> Will this affect the taverna parent/language build?
It should not affect it. However, sometime we should remove hibernate
related version numbers from the parent pom.
> Cheers,
>
> Ian
Alan
Re: Removal of hibernate dependency
Posted by Alan Williams <al...@googlemail.com>.
On 28-Jul-15 15:29, Ian Dunlop wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Hello,
>
> Will this affect the taverna parent/language build?
It should not affect it. However, sometime we should remove hibernate
related version numbers from the parent pom.
> Cheers,
>
> Ian
Alan
Re: Removal of hibernate dependency
Posted by Ian Dunlop <ia...@manchester.ac.uk>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Hello,
Will this affect the taverna parent/language build?
Cheers,
Ian
On 28/07/2015 14:48, alaninmcr wrote:
> Hello everybody,
>
> I have removed the hibernate dependency from
> taverna-reference-impl. There may be cascade effects that will need
> to be fixed as well.
>
> Alan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJVt5HhAAoJEPK45GBX+Cy5FXwIAJb9n5lCx4kFwBSYl5xF4Ypi
LNlYkgHHRQfuE4x2zM+HS1089FQxnRtCkMNn7oDfwJ6oOEpW5Qf4Iu1DRM2Q1Mk1
rmEd6S/utboFXkzEWbnbMywokh/2cW9oM8lLj27FpZohIm//aeQxfovoPcyWBS/+
6lAZ/eLviND6cxyCPauQLPnfjaRHl7wWV6/LibCSnRdaEfKEtl+rIaSBmOQMDgMH
cjXHmLNkc9DjRlW09G0vepQ9VgOc3YfHMcen6/VKAQFHnYbVc/4QP4kykOaSxnSn
7XsQRxYt2gfCx10fdHBEpeJi6600mAGZxzwAdTO/1/MSngCNVLsLvtOotX6+zzs=
=uqgz
-----END PGP SIGNATURE-----