[GitHub] [arrow] tolleybot commented on a diff in pull request #34616: GH-29238 [C++][Dataset][Parquet] Support parquet modular encryption in the new Dataset API

["tolleybot (via GitHub)" <gi...@apache.org>]

tolleybot commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1160936373


##########
cpp/src/parquet/encryption/dataset_encryption_config.h:
##########
@@ -0,0 +1,31 @@
+#pragma once
+
+#include "parquet/encryption/crypto_factory.h"
+#include "parquet/encryption/encryption.h"
+#include "parquet/encryption/kms_client.h"
+#include "arrow/dataset/type_fwd.h"

Review Comment:
   Ok, this is also related to your previous comment.  I'll make that change and change the namespace to arrow::dataset in addition changing the PARQUET_EXPORT to ARROW_DS_EXPORT



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org