You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/10 03:33:06 UTC
[GitHub] [helix] NealSun96 opened a new pull request #880: Fix
testInstancesStoppable_zoneBased
NealSun96 opened a new pull request #880: Fix testInstancesStoppable_zoneBased
URL: https://github.com/apache/helix/pull/880
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR description:
Fixes #879
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
The changes merged in https://github.com/apache/helix/pull/858 broke `testInstancesStoppable_zoneBased`. The test didn't create external views at all, which will encounter exceptions with the new logic.
The logic added wasn't supposed to break the tests because the logic is to perform null checks before an if condition that utilizes maps. However, the tests were passing because in the "and" if condition, it failed at `isPartitionMap.containsKey(instanceName)` without accessing the second part of the "and" condition. Therefore, even though the second part could cause an null pointer failure, it was never an issue. The fix is to reorder the logic such that the conditions are performed separately with null checks right before each map access.
### Tests
- [x] The following is the result of the "mvn test" command on the appropriate module:
Tests run: 99, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.142 sec - in TestSuite
Results :
Tests run: 99, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 25.069 s
[INFO] Finished at: 2020-03-09T20:25:23-07:00
[INFO] ------------------------------------------------------------------------
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [x] My diff has been formatted using helix-style.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang merged pull request #880: Fix
testInstancesStoppable_zoneBased
Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #880: Fix testInstancesStoppable_zoneBased
URL: https://github.com/apache/helix/pull/880
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on issue #880: Fix
testInstancesStoppable_zoneBased
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on issue #880: Fix testInstancesStoppable_zoneBased
URL: https://github.com/apache/helix/pull/880#issuecomment-597186776
This PR is ready to be merged, approved by @narendly
Final commit message:
## Fix testInstancesStoppable_zoneBased ##
The changes merged in https://github.com/apache/helix/pull/858 broke `testInstancesStoppable_zoneBased`. The test didn't create external views at all, which will encounter exceptions with the new logic.
The logic added wasn't supposed to break the tests because the logic is to perform null checks before an if condition that utilizes maps. However, the tests were passing because in the "and" if condition, it failed at `isPartitionMap.containsKey(instanceName)` without accessing the second part of the "and" condition. Therefore, even though the second part could cause a null pointer failure, it was never an issue. The fix is to reorder the logic such that the conditions are performed separately with null checks right before each map access.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org