[GitHub] [phoenix] priyankporwal commented on a change in pull request #669: PHOENIX-5651: IndexScrutiny does not handle TTL/row-expiry

[GitBox <gi...@apache.org>]

priyankporwal commented on a change in pull request #669: PHOENIX-5651: IndexScrutiny does not handle TTL/row-expiry
URL: https://github.com/apache/phoenix/pull/669#discussion_r362929563
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexScrutinyMapper.java
 ##########
 @@ -254,6 +291,47 @@ private void processBatch(Context context)
         }
     }
 
+    private void checkIfInvalidRowsExpired(Context context,
+            Map<String, Pair<Long,
+            List<Object>>> targetPkToSourceValues) throws SQLException, IOException {
+        long ttl = getTableTtl();
+        Set<Map.Entry<String, Pair<Long,
+                                List<Object>>>> entrySet = targetPkToSourceValues.entrySet();
+
+        Iterator<Map.Entry<String, Pair<Long,
+                        List<Object>>>> itr = entrySet.iterator();
 
 Review comment:
   nit: Splitting of these templatized types across multiple lines is making it worse than long lines. Missing typedefs in Java :|

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services