You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2023/01/11 20:30:10 UTC

[GitHub] [maven-resolver] cstamas commented on pull request #235: [MRESOLVER-298] Make javax.inject optional again

cstamas commented on PR #235:
URL: https://github.com/apache/maven-resolver/pull/235#issuecomment-1379447874

   > Call me stupid, but what makes it optional now? That the providers don't appear in the annoations and this avoids the transitive dep to `javax.inject`?
   
   No dependency or dep scope was changed, it was code, here https://github.com/apache/maven-resolver/pull/235/files#diff-530cadfdf6c10eff31703c1c50c7121f9c72c64a4f55c156428c7cc1113e6950R77-R86 This `private static` method is used with default ctor (when SL is used) and expected Provider on classpath. This is not the case anymore.
   
   Simple proof: the "demo snippets" now work from IDE (they have main method), before this change, on current master they do NOT work due same issue (as javax.inject is only in test scope).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org