You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@parquet.apache.org by uw...@apache.org on 2017/07/26 11:38:50 UTC

parquet-cpp git commit: PARQUET-1069: Use shared Arrow linkage in verify-release-candidate

Repository: parquet-cpp
Updated Branches:
  refs/heads/master cbdd9560e -> b3bbc3923


PARQUET-1069: Use shared Arrow linkage in verify-release-candidate

Author: Korn, Uwe <Uw...@blue-yonder.com>
Author: Uwe L. Korn <uw...@apache.org>

Closes #376 from xhochy/PARQUET-1069 and squashes the following commits:

4c65125 [Korn, Uwe] Support running tests on macOS in verify script
55cd3bf [Uwe L. Korn] PARQUET-1069: Use shared Arrow linkage in verify-release-candidate


Project: http://git-wip-us.apache.org/repos/asf/parquet-cpp/repo
Commit: http://git-wip-us.apache.org/repos/asf/parquet-cpp/commit/b3bbc392
Tree: http://git-wip-us.apache.org/repos/asf/parquet-cpp/tree/b3bbc392
Diff: http://git-wip-us.apache.org/repos/asf/parquet-cpp/diff/b3bbc392

Branch: refs/heads/master
Commit: b3bbc3923329237549f8f151e5ba2f1f270191e1
Parents: cbdd956
Author: Korn, Uwe <Uw...@blue-yonder.com>
Authored: Wed Jul 26 13:38:45 2017 +0200
Committer: Uwe L. Korn <uw...@apache.org>
Committed: Wed Jul 26 13:38:45 2017 +0200

----------------------------------------------------------------------
 build-support/run-test.sh            | 3 +++
 dev/release/verify-release-candidate | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/parquet-cpp/blob/b3bbc392/build-support/run-test.sh
----------------------------------------------------------------------
diff --git a/build-support/run-test.sh b/build-support/run-test.sh
index e8f39cd..7c3d8f6 100755
--- a/build-support/run-test.sh
+++ b/build-support/run-test.sh
@@ -107,6 +107,9 @@ function run_test() {
   # even when retries are successful.
   rm -f $XMLFILE
 
+  # This is needed for test execution on macOS with shared arrow linkage build
+  # via external project.
+  export LD_LIBRARY_PATH=${TEST_DIRNAME}:$LD_LIBRARY_PATH
   $TEST_EXECUTABLE "$@" 2>&1 \
     | c++filt \
     | $ROOT/build-support/stacktrace_addr2line.pl $TEST_EXECUTABLE \

http://git-wip-us.apache.org/repos/asf/parquet-cpp/blob/b3bbc392/dev/release/verify-release-candidate
----------------------------------------------------------------------
diff --git a/dev/release/verify-release-candidate b/dev/release/verify-release-candidate
index 278c1f2..9bdf2b0 100755
--- a/dev/release/verify-release-candidate
+++ b/dev/release/verify-release-candidate
@@ -50,7 +50,7 @@ run_tests() {
   # Build
   mkdir -p build
   cd build
-  cmake -DPARQUET_ARROW_LINKAGE=static ..
+  cmake ..
   make -j5
 
   # Test