You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "anujphadke (Code Review)" <ge...@cloudera.org> on 2016/06/29 20:50:23 UTC

[Impala-CR](cdh5-2.5.0 5.7.x) IMPALA-3751: fix clang build errors and warnings 

Hello Internal Jenkins, Tim Armstrong,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3539

to review the following change.

Change subject: IMPALA-3751: fix clang build errors and warnings
......................................................................

IMPALA-3751: fix clang build errors and warnings

Fix misc clang errors and warnings.

Change-Id: Ie71a483789d3be06248036ab3bbee82d66580973
Reviewed-on: http://gerrit.cloudera.org:8080/3391
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit ffd316090899367100787cf4a30615b7054ffe0b)
Reviewed-on: http://gerrit.sjc.cloudera.com:8080/13637
Tested-by: Anuj Phadke <ap...@cloudera.com>
(cherry picked from commit 9e29af9a0fa2c6271b73d09825608e4b6e74fc25)
---
M be/src/exec/hdfs-avro-scanner-test.cc
M be/src/exec/zigzag-test.cc
M be/src/udf/uda-test.cc
3 files changed, 7 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/39/3539/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie71a483789d3be06248036ab3bbee82d66580973
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.x
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-CR](cdh5-2.5.0 5.7.x) IMPALA-3751: fix clang build errors and warnings

Posted by "anujphadke (Code Review)" <ge...@cloudera.org>.
anujphadke has posted comments on this change.

Change subject: IMPALA-3751: fix clang build errors and warnings
......................................................................


Patch Set 1: Code-Review+2 Verified+1

http://sandbox.jenkins.cloudera.com/view/Impala/view/Private-Utility/job/impala-private-build-and-test/3551/

-- 
To view, visit http://gerrit.cloudera.org:8080/3539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie71a483789d3be06248036ab3bbee82d66580973
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.x
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-2.5.0 5.7.x) IMPALA-3751: fix clang build errors and warnings

Posted by "anujphadke (Code Review)" <ge...@cloudera.org>.
anujphadke has submitted this change and it was merged.

Change subject: IMPALA-3751: fix clang build errors and warnings
......................................................................


IMPALA-3751: fix clang build errors and warnings

Fix misc clang errors and warnings.

Change-Id: Ie71a483789d3be06248036ab3bbee82d66580973
Reviewed-on: http://gerrit.cloudera.org:8080/3391
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Internal Jenkins
(cherry picked from commit ffd316090899367100787cf4a30615b7054ffe0b)
Reviewed-on: http://gerrit.sjc.cloudera.com:8080/13637
Tested-by: Anuj Phadke <ap...@cloudera.com>
(cherry picked from commit 9e29af9a0fa2c6271b73d09825608e4b6e74fc25)
Reviewed-on: http://gerrit.cloudera.org:8080/3539
Reviewed-by: anujphadke <ap...@cloudera.com>
Tested-by: anujphadke <ap...@cloudera.com>
---
M be/src/exec/hdfs-avro-scanner-test.cc
M be/src/exec/zigzag-test.cc
M be/src/udf/uda-test.cc
3 files changed, 7 insertions(+), 8 deletions(-)

Approvals:
  anujphadke: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie71a483789d3be06248036ab3bbee82d66580973
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.5.0_5.7.x
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>