You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by ak...@apache.org on 2025/06/02 08:16:24 UTC
(buildstream) 02/02: Add note to update the requirements whenever the grpc code is regenerated
This is an automated email from the ASF dual-hosted git repository.
akitouni pushed a commit to branch abderrahim/protobuf-warnings
in repository https://gitbox.apache.org/repos/asf/buildstream.git
commit 5e9eb76017fc875461ee86f3ff6f398be3ee0b7f
Author: Abderrahim Kitouni <ab...@codethink.co.uk>
AuthorDate: Mon Jun 2 09:16:04 2025 +0100
Add note to update the requirements whenever the grpc code is regenerated
---
doc/source/hacking/grpc_protocols.rst | 3 +++
setup.py | 6 ++++++
2 files changed, 9 insertions(+)
diff --git a/doc/source/hacking/grpc_protocols.rst b/doc/source/hacking/grpc_protocols.rst
index 0ca4c743b..b0f9b414d 100644
--- a/doc/source/hacking/grpc_protocols.rst
+++ b/doc/source/hacking/grpc_protocols.rst
@@ -36,3 +36,6 @@ To actually regenerate the code::
./setup.py build_grpc
+The ``requirements/requirements.in`` file needs to be updated to match the
+protobuf version requirements of the ``grpcio-tools`` version used to
+generate the code.
diff --git a/setup.py b/setup.py
index 1e5887fec..fac86b726 100755
--- a/setup.py
+++ b/setup.py
@@ -202,6 +202,12 @@ class BuildGRPC(Command):
with open(path, "w", encoding="utf-8") as f:
f.write(code)
+ print(
+ "\n"
+ "NOTE: Please update requirements/requirements.in to match the protobuf\n"
+ "requirement in the grpcio-tools version you used."
+ )
+
def get_cmdclass():
cmdclass = {