You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Joel Koshy <jj...@gmail.com> on 2014/04/10 23:02:44 UTC

Review Request 20232: Avoid sending all topic metadata on state changes.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20232/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1355
    https://issues.apache.org/jira/browse/KAFKA-1355


Repository: kafka


Description
-------

KAFKA-1355; Avoid sending all topic metadata on state changes.


Diffs
-----

  core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala 03117377e1cb2ad63e4c7740d97ca9a4f20abeeb 
  core/src/main/scala/kafka/controller/ControllerChannelManager.scala f17d97603798e803d035f313f0165f11f6d0f2c0 
  core/src/main/scala/kafka/controller/KafkaController.scala d6c03218ec0afdb65a7b5aa9b85eb1c029357d7a 
  core/src/main/scala/kafka/controller/TopicDeletionManager.scala 40c4c5776b893890a30ad1e4b04f36aa1c112d80 
  core/src/main/scala/kafka/server/KafkaApis.scala 0f137c5136e2320ca27c285d6ab013f6559314c4 

Diff: https://reviews.apache.org/r/20232/diff/


Testing
-------


Thanks,

Joel Koshy

Re: Review Request 20232: Avoid sending all topic metadata on state changes.

Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20232/#review40159
-----------------------------------------------------------

Ship it!


Ship It!

- Guozhang Wang


On April 10, 2014, 9:02 p.m., Joel Koshy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20232/
> -----------------------------------------------------------
> 
> (Updated April 10, 2014, 9:02 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1355
>     https://issues.apache.org/jira/browse/KAFKA-1355
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1355; Avoid sending all topic metadata on state changes.
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala 03117377e1cb2ad63e4c7740d97ca9a4f20abeeb 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala f17d97603798e803d035f313f0165f11f6d0f2c0 
>   core/src/main/scala/kafka/controller/KafkaController.scala d6c03218ec0afdb65a7b5aa9b85eb1c029357d7a 
>   core/src/main/scala/kafka/controller/TopicDeletionManager.scala 40c4c5776b893890a30ad1e4b04f36aa1c112d80 
>   core/src/main/scala/kafka/server/KafkaApis.scala 0f137c5136e2320ca27c285d6ab013f6559314c4 
> 
> Diff: https://reviews.apache.org/r/20232/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joel Koshy
> 
>

Re: Review Request 20232: Avoid sending all topic metadata on state changes

Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20232/#review40729
-----------------------------------------------------------

Ship it!


Ship It!

- Guozhang Wang


On April 17, 2014, 9:49 p.m., Joel Koshy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20232/
> -----------------------------------------------------------
> 
> (Updated April 17, 2014, 9:49 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1355
>     https://issues.apache.org/jira/browse/KAFKA-1355
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1355; Avoid sending all topic metadata on state changes.
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala 03117377e1cb2ad63e4c7740d97ca9a4f20abeeb 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala f17d97603798e803d035f313f0165f11f6d0f2c0 
>   core/src/main/scala/kafka/controller/KafkaController.scala e225226e222f04b2687fabebe50d90fc0b0b3273 
>   core/src/main/scala/kafka/controller/TopicDeletionManager.scala 40c4c5776b893890a30ad1e4b04f36aa1c112d80 
>   core/src/main/scala/kafka/server/KafkaApis.scala b9d2260ae67522b02c21a2d52eeb827eca3643ee 
> 
> Diff: https://reviews.apache.org/r/20232/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joel Koshy
> 
>

Re: Review Request 20232: Avoid sending all topic metadata on state changes

Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20232/
-----------------------------------------------------------

(Updated April 17, 2014, 9:49 p.m.)


Review request for kafka.


Summary (updated)
-----------------

Avoid sending all topic metadata on state changes


Bugs: KAFKA-1355
    https://issues.apache.org/jira/browse/KAFKA-1355


Repository: kafka


Description
-------

KAFKA-1355; Avoid sending all topic metadata on state changes.


Diffs (updated)
-----

  core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala 03117377e1cb2ad63e4c7740d97ca9a4f20abeeb 
  core/src/main/scala/kafka/controller/ControllerChannelManager.scala f17d97603798e803d035f313f0165f11f6d0f2c0 
  core/src/main/scala/kafka/controller/KafkaController.scala e225226e222f04b2687fabebe50d90fc0b0b3273 
  core/src/main/scala/kafka/controller/TopicDeletionManager.scala 40c4c5776b893890a30ad1e4b04f36aa1c112d80 
  core/src/main/scala/kafka/server/KafkaApis.scala b9d2260ae67522b02c21a2d52eeb827eca3643ee 

Diff: https://reviews.apache.org/r/20232/diff/


Testing
-------


Thanks,

Joel Koshy

Re: Review Request 20232: Avoid sending all topic metadata on state changes.

Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20232/#review40166
-----------------------------------------------------------

Ship it!


Ship It!

- Neha Narkhede


On April 10, 2014, 9:02 p.m., Joel Koshy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20232/
> -----------------------------------------------------------
> 
> (Updated April 10, 2014, 9:02 p.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1355
>     https://issues.apache.org/jira/browse/KAFKA-1355
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAFKA-1355; Avoid sending all topic metadata on state changes.
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/api/LeaderAndIsrRequest.scala 03117377e1cb2ad63e4c7740d97ca9a4f20abeeb 
>   core/src/main/scala/kafka/controller/ControllerChannelManager.scala f17d97603798e803d035f313f0165f11f6d0f2c0 
>   core/src/main/scala/kafka/controller/KafkaController.scala d6c03218ec0afdb65a7b5aa9b85eb1c029357d7a 
>   core/src/main/scala/kafka/controller/TopicDeletionManager.scala 40c4c5776b893890a30ad1e4b04f36aa1c112d80 
>   core/src/main/scala/kafka/server/KafkaApis.scala 0f137c5136e2320ca27c285d6ab013f6559314c4 
> 
> Diff: https://reviews.apache.org/r/20232/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joel Koshy
> 
>