You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "JoeyJoeJoeJrShabadoo (via GitHub)" <gi...@apache.org> on 2024/11/02 15:42:26 UTC
[I] [Feature request] Please add vcpkg feature to enable Qt support [logging-log4cxx]
JoeyJoeJoeJrShabadoo opened a new issue, #423:
URL: https://github.com/apache/logging-log4cxx/issues/423
Hi everybody, first thanks a lot for your effort to maintain this terrific piece of software.
There's one thing I'd love to have in addition: Would it be possible to add a feature to the vcpkg port that enables the Qt support (LOG4CXX_QT_SUPPORT=ON)? I tried myself, but failed. What I mean is, if using vcpkg in manifest mode, it should be possible to do this in the vcpkg.json:
```
{
"dependencies": [
{
"name": "log4cxx",
"features": [ "qtsupport" ]
}
]
}
```
In my imagination, this would add LOG4CXX_QT_SUPPORT=ON to the build flags and do whatever else it needs to make things work automagically.
Thanks for considering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature request] Please add vcpkg feature to enable Qt support [logging-log4cxx]
Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 commented on issue #423:
URL: https://github.com/apache/logging-log4cxx/issues/423#issuecomment-2453320270
Thank you. I am happy you find the library useful.
I added a [PR to vcpkg](https://github.com/microsoft/vcpkg/pull/41928)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature request] Please add vcpkg feature to enable Qt support [logging-log4cxx]
Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 commented on issue #423:
URL: https://github.com/apache/logging-log4cxx/issues/423#issuecomment-2453623684
I have already [created a PR to update to 1.3.0](https://github.com/microsoft/vcpkg/pull/41927), but installing pkg_config files breaks vcpkg.
I think we will need to add a cmake option for pkg_config so pkf_config file installation can be switched off in vcpkg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature request] Please add vcpkg feature to enable Qt support [logging-log4cxx]
Posted by "rm5248 (via GitHub)" <gi...@apache.org>.
rm5248 commented on issue #423:
URL: https://github.com/apache/logging-log4cxx/issues/423#issuecomment-2453429545
should we also update the vcpkg version to 1.3.0? Although perhaps that should be a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature request] Please add vcpkg feature to enable Qt support [logging-log4cxx]
Posted by "JoeyJoeJoeJrShabadoo (via GitHub)" <gi...@apache.org>.
JoeyJoeJoeJrShabadoo commented on issue #423:
URL: https://github.com/apache/logging-log4cxx/issues/423#issuecomment-2453435020
Sounds reasonable to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature request] Please add vcpkg feature to enable Qt support [logging-log4cxx]
Posted by "JoeyJoeJoeJrShabadoo (via GitHub)" <gi...@apache.org>.
JoeyJoeJoeJrShabadoo commented on issue #423:
URL: https://github.com/apache/logging-log4cxx/issues/423#issuecomment-2463119545
Closing the issue as completed. Thank you for the implementation, I appreciate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature request] Please add vcpkg feature to enable Qt support [logging-log4cxx]
Posted by "JoeyJoeJoeJrShabadoo (via GitHub)" <gi...@apache.org>.
JoeyJoeJoeJrShabadoo commented on issue #423:
URL: https://github.com/apache/logging-log4cxx/issues/423#issuecomment-2453428302
Wow, that was pretty quick, thank you very much, Stephen. As a additional benefit I can see now what I was missing when trying myself 👍
I'll wait till the PR is merged and close the issue then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature request] Please add vcpkg feature to enable Qt support [logging-log4cxx]
Posted by "JoeyJoeJoeJrShabadoo (via GitHub)" <gi...@apache.org>.
JoeyJoeJoeJrShabadoo closed issue #423: [Feature request] Please add vcpkg feature to enable Qt support
URL: https://github.com/apache/logging-log4cxx/issues/423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org