You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/27 10:44:22 UTC

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #521: feat: Refactor Frondend with Admin API

juzhiyuan opened a new pull request #521:
URL: https://github.com/apache/apisix-dashboard/pull/521


   - [ ] Upstream
   - [ ] Route
   - [ ] SSL
   - [ ] Consumer


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #521: feat: Refactor Frondend with Admin API

Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #521:
URL: https://github.com/apache/apisix-dashboard/pull/521#discussion_r503868860



##########
File path: src/pages/Route/components/Step2/RequestRewriteView.tsx
##########
@@ -29,7 +29,7 @@ const RequestRewriteView: React.FC<RouteModule.Step2PassProps> = ({
     fetchUpstreamList().then(({ data }) => setList(data));
   }, []);
   return (
-    <UpstreamForm ref={upstreamRef} form={form} disabled={disabled} list={list} showSelector />
+    <UpstreamForm ref={upstreamRef} form={form} disabled={disabled} list={list} showSelector key={1} />

Review comment:
       this key uses for fix route step2 warnings.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #521: feat: Refactor Frondend with Admin API

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #521:
URL: https://github.com/apache/apisix-dashboard/pull/521#discussion_r505136290



##########
File path: src/pages/Route/components/Step1/RequestConfigView.tsx
##########
@@ -99,8 +99,8 @@ const RequestConfigView: React.FC<RouteModule.Step1PassProps> = ({
     </Form.List>
   );
 
-  const renderPaths = () => (
-    <Form.List name="paths">
+  const renderUris = () => (

Review comment:
       <URIList />




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #521: feat: Refactor Frondend with Admin API

Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on pull request #521:
URL: https://github.com/apache/apisix-dashboard/pull/521#issuecomment-709940591


   @moonming Please check if there have any License issues.
   
   @liuxiran @bzp2010 Please take a looks at those code changes.
   
   This PR is going to merge into the master branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #521: feat: Refactor Frondend with Admin API

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #521:
URL: https://github.com/apache/apisix-dashboard/pull/521#issuecomment-709940591


   @moonming Please check if there have any License issues.
   
   @liuxiran @bzp2010 Please take a looks at those code changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #521: feat: Refactor Frondend with Admin API

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #521:
URL: https://github.com/apache/apisix-dashboard/pull/521#discussion_r503653883



##########
File path: src/pages/Route/transform.ts
##########
@@ -77,6 +77,8 @@ export const transformStepData = ({
       'redirectURI',
       'ret_code',
       'redirectOption',
+      !Object.keys(step3Data.plugins).length ? 'plugins' : '',

Review comment:
       Why we need `!`? @LiteSun 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] moonming commented on pull request #521: feat: Refactor Frondend with Admin API

Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #521:
URL: https://github.com/apache/apisix-dashboard/pull/521#issuecomment-711837581


   got it
   Thanks,
   Ming Wen
   Twitter: _WenMing
   
   
   琚致远 <no...@github.com> 于2020年10月19日周一 下午4:15写道：
   
   > cc @moonming <https://github.com/moonming> @liuxiran
   > <https://github.com/liuxiran> This PR is going to merge into the master
   > branch, and it depends on the api refactor branch, so it means the master
   > branch is unstable after this PR is merged, @nic-chen
   > <https://github.com/nic-chen> @ShiningRush
   > <https://github.com/ShiningRush> please Pull Request the refactor branch
   > once it’s ready.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/apisix-dashboard/pull/521#issuecomment-711815099>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AGJZBK4BNNT7KO3FPTK6YNDSLPYSNANCNFSM4R3PNEPQ>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #521: feat: Refactor Frondend with Admin API

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #521:
URL: https://github.com/apache/apisix-dashboard/pull/521#discussion_r503836977



##########
File path: src/pages/Route/components/Step2/RequestRewriteView.tsx
##########
@@ -29,7 +29,7 @@ const RequestRewriteView: React.FC<RouteModule.Step2PassProps> = ({
     fetchUpstreamList().then(({ data }) => setList(data));
   }, []);
   return (
-    <UpstreamForm ref={upstreamRef} form={form} disabled={disabled} list={list} showSelector />
+    <UpstreamForm ref={upstreamRef} form={form} disabled={disabled} list={list} showSelector key={1} />

Review comment:
       Why we need this key?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #521: feat: Refactor Frondend with Admin API

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #521:
URL: https://github.com/apache/apisix-dashboard/pull/521#issuecomment-712946049


   ping @moonming @liuxiran 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #521: feat: Refactor Frondend with Admin API

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #521:
URL: https://github.com/apache/apisix-dashboard/pull/521


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #521: feat: Refactor Frondend with Admin API

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #521:
URL: https://github.com/apache/apisix-dashboard/pull/521#discussion_r505136290



##########
File path: src/pages/Route/components/Step1/RequestConfigView.tsx
##########
@@ -99,8 +99,8 @@ const RequestConfigView: React.FC<RouteModule.Step1PassProps> = ({
     </Form.List>
   );
 
-  const renderPaths = () => (
-    <Form.List name="paths">
+  const renderUris = () => (

Review comment:
       ```tsx
   <URIList />
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #521: feat: Refactor Frondend with Admin API

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #521:
URL: https://github.com/apache/apisix-dashboard/pull/521#issuecomment-712554862


   There would have a lot conflict changes, once the refactor branch is merged into master, we will handle those conflicts


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #521: feat: Refactor Frondend with Admin API

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #521:
URL: https://github.com/apache/apisix-dashboard/pull/521#issuecomment-711815099


   cc @moonming @liuxiran This PR is going to merge into the master branch, and it depends on the api refactor branch, so it means the master branch is unstable after this PR is merged, @nic-chen @ShiningRush please Pull Request the refactor branch once it’s ready.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on pull request #521: feat: Refactor Frondend with Admin API

Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on pull request #521:
URL: https://github.com/apache/apisix-dashboard/pull/521#issuecomment-712554862


   There would have a lot of conflict changes, once the refactor branch is merged into master, we will handle those conflicts


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #521: feat: Refactor Frondend with Admin API

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #521:
URL: https://github.com/apache/apisix-dashboard/pull/521#discussion_r505136985



##########
File path: src/pages/Route/components/Step1/RequestConfigView.tsx
##########
@@ -99,8 +99,8 @@ const RequestConfigView: React.FC<RouteModule.Step1PassProps> = ({
     </Form.List>
   );
 
-  const renderPaths = () => (
-    <Form.List name="paths">
+  const renderUris = () => (

Review comment:
       <URIList />




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org