You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Seetharam Venkatesh (JIRA)" <ji...@apache.org> on 2012/08/18 01:56:37 UTC
[jira] [Created] (SQOOP-582) Create a template method for job
submission in Export/Import JobBase
Seetharam Venkatesh created SQOOP-582:
-----------------------------------------
Summary: Create a template method for job submission in Export/Import JobBase
Key: SQOOP-582
URL: https://issues.apache.org/jira/browse/SQOOP-582
Project: Sqoop
Issue Type: Bug
Components: connectors
Affects Versions: 1.4.1-incubating
Reporter: Seetharam Venkatesh
Assignee: Seetharam Venkatesh
Priority: Minor
Currently the job submission is synchronous and waits for job to complete. There are use cases when a connector needs to submit job and do other things while the job is in progress retaining the code to extract counters.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-582) Create a template method for job
submission in Export/Import JobBase
Posted by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438488#comment-13438488 ]
Jarek Jarcec Cecho commented on SQOOP-582:
------------------------------------------
Thanks Venkatesh for your comment,
I believe that current patch make sense. It's pretty simple patch, so I'm bypassing review board and giving my +1 here.
Jarcec
> Create a template method for job submission in Export/Import JobBase
> --------------------------------------------------------------------
>
> Key: SQOOP-582
> URL: https://issues.apache.org/jira/browse/SQOOP-582
> Project: Sqoop
> Issue Type: Bug
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Attachments: SQOOP-582.patch
>
>
> Currently the job submission is synchronous and waits for job to complete. There are use cases when a connector needs to submit job and do other things while the job is in progress retaining the code to extract counters.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-582) Create a template method for job
submission in Export/Import JobBase
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438513#comment-13438513 ]
Hudson commented on SQOOP-582:
------------------------------
Integrated in Sqoop-ant-jdk-1.6-hadoop100 #12 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/12/])
SQOOP-582. Create a template method for job submission in Export/Import JobBase.
(Seetharam Venkatesh via Jarek Jarcec Cecho) (Revision 1375395)
Result = SUCCESS
jarcec :
Files :
* /sqoop/trunk/src/java/org/apache/sqoop/mapreduce/ExportJobBase.java
* /sqoop/trunk/src/java/org/apache/sqoop/mapreduce/ImportJobBase.java
> Create a template method for job submission in Export/Import JobBase
> --------------------------------------------------------------------
>
> Key: SQOOP-582
> URL: https://issues.apache.org/jira/browse/SQOOP-582
> Project: Sqoop
> Issue Type: Bug
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Fix For: 1.4.3
>
> Attachments: SQOOP-582.patch
>
>
> Currently the job submission is synchronous and waits for job to complete. There are use cases when a connector needs to submit job and do other things while the job is in progress retaining the code to extract counters.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-582) Create a template method for job
submission in Export/Import JobBase
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438501#comment-13438501 ]
Hudson commented on SQOOP-582:
------------------------------
Integrated in Sqoop-ant-jdk-1.6-hadoop20 #12 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/12/])
SQOOP-582. Create a template method for job submission in Export/Import JobBase.
(Seetharam Venkatesh via Jarek Jarcec Cecho) (Revision 1375395)
Result = SUCCESS
jarcec :
Files :
* /sqoop/trunk/src/java/org/apache/sqoop/mapreduce/ExportJobBase.java
* /sqoop/trunk/src/java/org/apache/sqoop/mapreduce/ImportJobBase.java
> Create a template method for job submission in Export/Import JobBase
> --------------------------------------------------------------------
>
> Key: SQOOP-582
> URL: https://issues.apache.org/jira/browse/SQOOP-582
> Project: Sqoop
> Issue Type: Bug
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Fix For: 1.4.3
>
> Attachments: SQOOP-582.patch
>
>
> Currently the job submission is synchronous and waits for job to complete. There are use cases when a connector needs to submit job and do other things while the job is in progress retaining the code to extract counters.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-582) Create a template method for job
submission in Export/Import JobBase
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438510#comment-13438510 ]
Hudson commented on SQOOP-582:
------------------------------
Integrated in Sqoop-ant-jdk-1.6-hadoop23 #142 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/142/])
SQOOP-582. Create a template method for job submission in Export/Import JobBase.
(Seetharam Venkatesh via Jarek Jarcec Cecho) (Revision 1375395)
Result = SUCCESS
jarcec :
Files :
* /sqoop/trunk/src/java/org/apache/sqoop/mapreduce/ExportJobBase.java
* /sqoop/trunk/src/java/org/apache/sqoop/mapreduce/ImportJobBase.java
> Create a template method for job submission in Export/Import JobBase
> --------------------------------------------------------------------
>
> Key: SQOOP-582
> URL: https://issues.apache.org/jira/browse/SQOOP-582
> Project: Sqoop
> Issue Type: Bug
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Fix For: 1.4.3
>
> Attachments: SQOOP-582.patch
>
>
> Currently the job submission is synchronous and waits for job to complete. There are use cases when a connector needs to submit job and do other things while the job is in progress retaining the code to extract counters.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-582) Create a template method for job
submission in Export/Import JobBase
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438505#comment-13438505 ]
Hudson commented on SQOOP-582:
------------------------------
Integrated in Sqoop-ant-jdk-1.6-hadoop200 #3 (See [https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/3/])
SQOOP-582. Create a template method for job submission in Export/Import JobBase.
(Seetharam Venkatesh via Jarek Jarcec Cecho) (Revision 1375395)
Result = SUCCESS
jarcec :
Files :
* /sqoop/trunk/src/java/org/apache/sqoop/mapreduce/ExportJobBase.java
* /sqoop/trunk/src/java/org/apache/sqoop/mapreduce/ImportJobBase.java
> Create a template method for job submission in Export/Import JobBase
> --------------------------------------------------------------------
>
> Key: SQOOP-582
> URL: https://issues.apache.org/jira/browse/SQOOP-582
> Project: Sqoop
> Issue Type: Bug
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Fix For: 1.4.3
>
> Attachments: SQOOP-582.patch
>
>
> Currently the job submission is synchronous and waits for job to complete. There are use cases when a connector needs to submit job and do other things while the job is in progress retaining the code to extract counters.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-582) Create a template method for job
submission in Export/Import JobBase
Posted by "Abhijeet Gaikwad (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437473#comment-13437473 ]
Abhijeet Gaikwad commented on SQOOP-582:
----------------------------------------
I see redundant code. Can we move doSubmitJob() method to JobBase class. Also change JobBase.runJob() accordingly.
Let me know.
Thanks.
> Create a template method for job submission in Export/Import JobBase
> --------------------------------------------------------------------
>
> Key: SQOOP-582
> URL: https://issues.apache.org/jira/browse/SQOOP-582
> Project: Sqoop
> Issue Type: Bug
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Attachments: SQOOP-582.patch
>
>
> Currently the job submission is synchronous and waits for job to complete. There are use cases when a connector needs to submit job and do other things while the job is in progress retaining the code to extract counters.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SQOOP-582) Create a template method for job
submission in Export/Import JobBase
Posted by "Seetharam Venkatesh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Seetharam Venkatesh updated SQOOP-582:
--------------------------------------
Attachment: SQOOP-582.patch
> Create a template method for job submission in Export/Import JobBase
> --------------------------------------------------------------------
>
> Key: SQOOP-582
> URL: https://issues.apache.org/jira/browse/SQOOP-582
> Project: Sqoop
> Issue Type: Bug
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Attachments: SQOOP-582.patch
>
>
> Currently the job submission is synchronous and waits for job to complete. There are use cases when a connector needs to submit job and do other things while the job is in progress retaining the code to extract counters.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SQOOP-582) Create a template method for job
submission in Export/Import JobBase
Posted by "Seetharam Venkatesh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SQOOP-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438125#comment-13438125 ]
Seetharam Venkatesh commented on SQOOP-582:
-------------------------------------------
Well, you need to look at the implementations carefully to observe that it is necessary to duplicate the code. The runJob in itself is a template method that is overridden by Import and Export and the counter read by each of these are different.
I could copy the doSubmitJob method to the base class but using it in runJob does not make sense IMO. Do you prefer the former?
> Create a template method for job submission in Export/Import JobBase
> --------------------------------------------------------------------
>
> Key: SQOOP-582
> URL: https://issues.apache.org/jira/browse/SQOOP-582
> Project: Sqoop
> Issue Type: Bug
> Components: connectors
> Affects Versions: 1.4.1-incubating
> Reporter: Seetharam Venkatesh
> Assignee: Seetharam Venkatesh
> Priority: Minor
> Attachments: SQOOP-582.patch
>
>
> Currently the job submission is synchronous and waits for job to complete. There are use cases when a connector needs to submit job and do other things while the job is in progress retaining the code to extract counters.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira