You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "DMwangnima (via GitHub)" <gi...@apache.org> on 2023/11/07 14:46:05 UTC
Re: [PR] feat: update protoc-gen-triple [dubbo-go]
DMwangnima commented on code in PR #2489:
URL: https://github.com/apache/dubbo-go/pull/2489#discussion_r1385033313
##########
protocol/triple/triple-tool/protoc-gen-go-triple/main.go:
##########
@@ -51,19 +53,41 @@ func main() {
os.Exit(1)
}
- protogen.Options{}.Run(
+ var flags flag.FlagSet
+ useOld := flags.Bool("useOldVersion", false, "print the version and exit")
Review Comment:
@chickenlj We need to talk about this flag to make it more intuitive. And we use ```go-triple_opt=useOldVersion=true``` as temporary placeholder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org