You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2011/12/16 02:12:08 UTC
Review Request: Master should reply with TASK_LOST incase of failures
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3220/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and John Sirois.
Summary
-------
TASK_FAILED messages should only come from the framework, so that debugging is easy.
Diffs
-----
src/tests/resource_offers_tests.cpp 8e1061e
src/master/master.cpp ede831e
Diff: https://reviews.apache.org/r/3220/diff
Testing
-------
./bin/tests/all-tests
Thanks,
Vinod
Re: Review Request: Master should reply with TASK_LOST incase of failures
Posted by Charles Reiss <wo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3220/#review4705
-----------------------------------------------------------
I think this has been committed (and should be marked as such).
- Charles
On 2011-12-16 01:12:08, Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3220/
> -----------------------------------------------------------
>
> (Updated 2011-12-16 01:12:08)
>
>
> Review request for mesos, Benjamin Hindman and John Sirois.
>
>
> Summary
> -------
>
> TASK_FAILED messages should only come from the framework, so that debugging is easy.
>
>
> Diffs
> -----
>
> src/tests/resource_offers_tests.cpp 8e1061e
> src/master/master.cpp ede831e
>
> Diff: https://reviews.apache.org/r/3220/diff
>
>
> Testing
> -------
>
> ./bin/tests/all-tests
>
>
> Thanks,
>
> Vinod
>
>
Re: Review Request: Master should reply with TASK_LOST incase of failures
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3220/#review3940
-----------------------------------------------------------
Ship it!
Hotness, thanks Vinod! Maybe throw a TODO where we use TASK_LOST but maybe would prefer TASK_INVALID?
- Benjamin
On 2011-12-16 01:12:08, Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3220/
> -----------------------------------------------------------
>
> (Updated 2011-12-16 01:12:08)
>
>
> Review request for mesos, Benjamin Hindman and John Sirois.
>
>
> Summary
> -------
>
> TASK_FAILED messages should only come from the framework, so that debugging is easy.
>
>
> Diffs
> -----
>
> src/tests/resource_offers_tests.cpp 8e1061e
> src/master/master.cpp ede831e
>
> Diff: https://reviews.apache.org/r/3220/diff
>
>
> Testing
> -------
>
> ./bin/tests/all-tests
>
>
> Thanks,
>
> Vinod
>
>