You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cassandra.apache.org by "Sam Tunnicliffe (JIRA)" <ji...@apache.org> on 2018/05/09 18:43:00 UTC

[jira] [Commented] (CASSANDRA-14416) Remove string formatting lines from hot path

    [ https://issues.apache.org/jira/browse/CASSANDRA-14416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469280#comment-16469280 ] 

Sam Tunnicliffe commented on CASSANDRA-14416:
---------------------------------------------

[~jjirsa] I just committed the dtest fix (for CASSANDRA-14420), so you might want to re-run CI now.

> Remove string formatting lines from hot path
> --------------------------------------------
>
>                 Key: CASSANDRA-14416
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14416
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jeff Jirsa
>            Assignee: Jeff Jirsa
>            Priority: Minor
>              Labels: performance
>             Fix For: 3.11.x, 4.x
>
>
> In the BufferPool, we have a {{NoSpamLogger}} that gets called in some conditions (like when we're at or near the cap in a given pool), which has some string formatting on it. In situations where that log line is invoked, that string formatting gets called before the rate limiting, which becomes expensive. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org