You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2015/09/16 18:14:30 UTC
[GitHub] flink pull request: [FLINK-2689] [runtime] Fix reuse of null objec...
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/1136
[FLINK-2689] [runtime] Fix reuse of null object for solution set Joins and CoGroups
Reuse object can become null if not match is found in the hash table. The next look-up will happen with a null-valued reuse object and fail.
This patch takes care that the reuse object does not become null.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink solutionSetJoinFix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1136.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1136
----
commit aa223335af19c5ff779c5f689a7f26cd8732c705
Author: Fabian Hueske <fh...@apache.org>
Date: 2015-09-16T14:56:06Z
[FLINK-2689] [runtime] Fix reuse of null object for solution set Joins and CoGroups.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2689] [runtime] Fix reuse of null objec...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2689] [runtime] Fix reuse of null objec...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1136#issuecomment-141168778
Hi @srowen, thank you for notifying us. We were trying out https://github.com/databricks/spark-pr-dashboard on Google App Engine (because we are also getting more and more flooded by pull requests ;) ). It seems that we didn't properly configure and test the tool before starting it.
After you told us about the issue, we immediately stopped the tool. You can also see from Max (@mxm)'s JIRA activity (https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mxm) that he stopped changing Spark JIRAs.
I'm really sorry that this has happened.
We'll manually clean up the Spark JIRAs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2689] [runtime] Fix reuse of null objec...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1136#issuecomment-141006389
Thanks for the review.
Will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2689] [runtime] Fix reuse of null objec...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1136#issuecomment-141003929
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2689] [runtime] Fix reuse of null objec...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/flink/pull/1136#issuecomment-141122197
@fhueske not sure where else to mention this, but for some reason, PRs like this are causing Apache JIRA to comment on Spark JIRAs (see https://issues.apache.org/jira/browse/SPARK-2689 for instance). Is it maybe because the merge script or other setup from Spark is also used in Flink? Maybe something wasn't changed. Not a huge deal but worth tracking down
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---