[GitHub] [incubator-superset] villebro commented on a change in pull request #9161: fix: share column type matching between model and result set

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #9161: fix: share column type matching between model and result set
URL: https://github.com/apache/incubator-superset/pull/9161#discussion_r381529090
 
 

 ##########
 File path: superset/utils/core.py
 ##########
 @@ -1227,11 +1227,58 @@ class TimeRangeEndpoint(str, Enum):
     UNKNOWN = "unknown"
 
 
-class ReservedUrlParameters(Enum):
+class ReservedUrlParameters(str, Enum):
     """
     Reserved URL parameters that are used internally by Superset. These will not be
     passed to chart queries, as they control the behavior of the UI.
     """
 
     STANDALONE = "standalone"
     EDIT_MODE = "edit"
+
+
+_DB_COLUMN_TYPES_NUMERIC: Tuple[str, ...] = (
 
 Review comment:
   Now that you mention it, yes they should be moved over to db engine specs. Will do so.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org