You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/03/29 08:33:48 UTC
[GitHub] [incubator-hudi] vinothchandar opened a new pull request #1462:
[WIP] [HUDI-744] Restructure hudi-common and clean up files under util
packages
vinothchandar opened a new pull request #1462: [WIP] [HUDI-744] Restructure hudi-common and clean up files under util packages
URL: https://github.com/apache/incubator-hudi/pull/1462
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
Brings more order and cohesion to the classes in hudi-common
## Brief change log
- Utils classes related to a particular concept (avro, timeline,...) are placed near to the package
- common.fs package now contains all the filesystem level classes including wrapper filesystem
- bloom.filter package renamed to just bloom
- config package contains classes that help store properties
- common.fs.inline package contains all the inline filesystem classes/impl
- common.table.timeline now consolidates all timeline related classes
- common.table.view consolidates all the classes related to filesystem view metadata
- common.table.timeline.versioning contains all classes related to versioning of timeline
- Fix few unit tests as a result
- Moved the test packages around to match the source file move
## Verify this pull request
This pull request is already covered by existing tests,
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar merged pull request #1462:
[HUDI-744] Restructure hudi-common and clean up files under util packages
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1462: [HUDI-744] Restructure hudi-common and clean up files under util packages
URL: https://github.com/apache/incubator-hudi/pull/1462
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1462:
[HUDI-744] Restructure hudi-common and clean up files under util packages
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1462: [HUDI-744] Restructure hudi-common and clean up files under util packages
URL: https://github.com/apache/incubator-hudi/pull/1462#issuecomment-605662273
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=h1) Report
> Merging [#1462](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/07c3c5d797f612f9b73b2805b65275c2029c2442&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1462 +/- ##
============================================
- Coverage 67.62% 67.60% -0.02%
Complexity 261 261
============================================
Files 348 348
Lines 16670 16670
Branches 1693 1693
============================================
- Hits 11273 11270 -3
- Misses 4658 4661 +3
Partials 739 739
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/hudi/client/AbstractHoodieClient.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0Fic3RyYWN0SG9vZGllQ2xpZW50LmphdmE=) | `76.31% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L2VtYmVkZGVkL0VtYmVkZGVkVGltZWxpbmVTZXJ2aWNlLmphdmE=) | `74.28% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...java/org/apache/hudi/client/utils/ClientUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL0NsaWVudFV0aWxzLmphdmE=) | `75.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...org/apache/hudi/config/HoodieCompactionConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZUNvbXBhY3Rpb25Db25maWcuamF2YQ==) | `81.37% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...org/apache/hudi/config/HoodieHBaseIndexConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZUhCYXNlSW5kZXhDb25maWcuamF2YQ==) | `46.66% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...java/org/apache/hudi/config/HoodieIndexConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZUluZGV4Q29uZmlnLmphdmE=) | `63.49% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ava/org/apache/hudi/config/HoodieMemoryConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZU1lbW9yeUNvbmZpZy5qYXZh) | `60.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...va/org/apache/hudi/config/HoodieMetricsConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZU1ldHJpY3NDb25maWcuamF2YQ==) | `52.77% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...va/org/apache/hudi/config/HoodieStorageConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZVN0b3JhZ2VDb25maWcuamF2YQ==) | `69.76% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZVdyaXRlQ29uZmlnLmphdmE=) | `84.37% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [157 more](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=footer). Last update [07c3c5d...b1d64ff](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1462:
[HUDI-744] Restructure hudi-common and clean up files under util packages
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1462: [HUDI-744] Restructure hudi-common and clean up files under util packages
URL: https://github.com/apache/incubator-hudi/pull/1462#issuecomment-605662273
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=h1) Report
> Merging [#1462](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/07c3c5d797f612f9b73b2805b65275c2029c2442&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1462 +/- ##
============================================
- Coverage 67.62% 67.60% -0.02%
Complexity 261 261
============================================
Files 348 348
Lines 16670 16670
Branches 1693 1693
============================================
- Hits 11273 11270 -3
- Misses 4658 4661 +3
Partials 739 739
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/hudi/client/AbstractHoodieClient.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0Fic3RyYWN0SG9vZGllQ2xpZW50LmphdmE=) | `76.31% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L2VtYmVkZGVkL0VtYmVkZGVkVGltZWxpbmVTZXJ2aWNlLmphdmE=) | `74.28% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...java/org/apache/hudi/client/utils/ClientUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL0NsaWVudFV0aWxzLmphdmE=) | `75.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...org/apache/hudi/config/HoodieCompactionConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZUNvbXBhY3Rpb25Db25maWcuamF2YQ==) | `81.37% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...org/apache/hudi/config/HoodieHBaseIndexConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZUhCYXNlSW5kZXhDb25maWcuamF2YQ==) | `46.66% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...java/org/apache/hudi/config/HoodieIndexConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZUluZGV4Q29uZmlnLmphdmE=) | `63.49% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ava/org/apache/hudi/config/HoodieMemoryConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZU1lbW9yeUNvbmZpZy5qYXZh) | `60.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...va/org/apache/hudi/config/HoodieMetricsConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZU1ldHJpY3NDb25maWcuamF2YQ==) | `52.77% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...va/org/apache/hudi/config/HoodieStorageConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZVN0b3JhZ2VDb25maWcuamF2YQ==) | `69.76% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZVdyaXRlQ29uZmlnLmphdmE=) | `84.37% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [157 more](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=footer). Last update [07c3c5d...b1d64ff](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] codecov-io commented on issue #1462: [HUDI-744]
Restructure hudi-common and clean up files under util packages
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1462: [HUDI-744] Restructure hudi-common and clean up files under util packages
URL: https://github.com/apache/incubator-hudi/pull/1462#issuecomment-605662273
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=h1) Report
> Merging [#1462](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/07c3c5d797f612f9b73b2805b65275c2029c2442&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1462 +/- ##
============================================
- Coverage 67.62% 67.60% -0.02%
Complexity 261 261
============================================
Files 348 348
Lines 16670 16670
Branches 1693 1693
============================================
- Hits 11273 11270 -3
- Misses 4658 4661 +3
Partials 739 739
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/hudi/client/AbstractHoodieClient.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0Fic3RyYWN0SG9vZGllQ2xpZW50LmphdmE=) | `76.31% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L2VtYmVkZGVkL0VtYmVkZGVkVGltZWxpbmVTZXJ2aWNlLmphdmE=) | `74.28% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...java/org/apache/hudi/client/utils/ClientUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL0NsaWVudFV0aWxzLmphdmE=) | `75.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...org/apache/hudi/config/HoodieCompactionConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZUNvbXBhY3Rpb25Db25maWcuamF2YQ==) | `81.37% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...org/apache/hudi/config/HoodieHBaseIndexConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZUhCYXNlSW5kZXhDb25maWcuamF2YQ==) | `46.66% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...java/org/apache/hudi/config/HoodieIndexConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZUluZGV4Q29uZmlnLmphdmE=) | `63.49% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ava/org/apache/hudi/config/HoodieMemoryConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZU1lbW9yeUNvbmZpZy5qYXZh) | `60.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...va/org/apache/hudi/config/HoodieMetricsConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZU1ldHJpY3NDb25maWcuamF2YQ==) | `52.77% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...va/org/apache/hudi/config/HoodieStorageConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZVN0b3JhZ2VDb25maWcuamF2YQ==) | `69.76% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZVdyaXRlQ29uZmlnLmphdmE=) | `84.37% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [157 more](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=footer). Last update [07c3c5d...b1d64ff](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] codecov-io edited a comment on issue #1462:
[HUDI-744] Restructure hudi-common and clean up files under util packages
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1462: [HUDI-744] Restructure hudi-common and clean up files under util packages
URL: https://github.com/apache/incubator-hudi/pull/1462#issuecomment-605662273
# [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=h1) Report
> Merging [#1462](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/07c3c5d797f612f9b73b2805b65275c2029c2442&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1462 +/- ##
============================================
- Coverage 67.62% 67.60% -0.02%
Complexity 261 261
============================================
Files 348 348
Lines 16670 16670
Branches 1693 1693
============================================
- Hits 11273 11270 -3
- Misses 4658 4661 +3
Partials 739 739
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/hudi/client/AbstractHoodieClient.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0Fic3RyYWN0SG9vZGllQ2xpZW50LmphdmE=) | `76.31% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../hudi/client/embedded/EmbeddedTimelineService.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L2VtYmVkZGVkL0VtYmVkZGVkVGltZWxpbmVTZXJ2aWNlLmphdmE=) | `74.28% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...java/org/apache/hudi/client/utils/ClientUtils.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L3V0aWxzL0NsaWVudFV0aWxzLmphdmE=) | `75.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...org/apache/hudi/config/HoodieCompactionConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZUNvbXBhY3Rpb25Db25maWcuamF2YQ==) | `81.37% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...org/apache/hudi/config/HoodieHBaseIndexConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZUhCYXNlSW5kZXhDb25maWcuamF2YQ==) | `46.66% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...java/org/apache/hudi/config/HoodieIndexConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZUluZGV4Q29uZmlnLmphdmE=) | `63.49% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ava/org/apache/hudi/config/HoodieMemoryConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZU1lbW9yeUNvbmZpZy5qYXZh) | `60.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...va/org/apache/hudi/config/HoodieMetricsConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZU1ldHJpY3NDb25maWcuamF2YQ==) | `52.77% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...va/org/apache/hudi/config/HoodieStorageConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZVN0b3JhZ2VDb25maWcuamF2YQ==) | `69.76% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZVdyaXRlQ29uZmlnLmphdmE=) | `84.37% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [157 more](https://codecov.io/gh/apache/incubator-hudi/pull/1462/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=footer). Last update [07c3c5d...b1d64ff](https://codecov.io/gh/apache/incubator-hudi/pull/1462?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services