You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/21 20:41:07 UTC
[GitHub] [spark] huaxingao commented on a change in pull request #29799: [SPARK-32933][PYTHON] Use keyword-only syntax for keyword_only methods
huaxingao commented on a change in pull request #29799:
URL: https://github.com/apache/spark/pull/29799#discussion_r492333261
##########
File path: python/pyspark/ml/classification.py
##########
@@ -3215,13 +3215,13 @@ def __init__(self, featuresCol="features", labelCol="label", predictionCol="pred
@keyword_only
@since("3.0.0")
- def setParams(self, featuresCol="features", labelCol="label", predictionCol="prediction",
+ def setParams(self, *, featuresCol="features", labelCol="label", predictionCol="prediction",
probabilityCol="probability", rawPredictionCol="rawPrediction",
factorSize=8, fitIntercept=True, fitLinear=True, regParam=0.0,
miniBatchFraction=1.0, initStd=0.01, maxIter=100, stepSize=1.0,
tol=1e-6, solver="adamW", thresholds=None, seed=None):
"""
- setParams(self, featuresCol="features", labelCol="label", predictionCol="prediction", \
+ setParams(self, \\*, eaturesCol="features", labelCol="label", predictionCol="prediction", \
Review comment:
typo ```eaturesCol```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org