[GitHub] [hive] szlta commented on a diff in pull request #3203: HIVE-26137 Optimized transfer of Iceberg residual expressions from AM to execution

[GitBox <gi...@apache.org>]

szlta commented on code in PR #3203:
URL: https://github.com/apache/hive/pull/3203#discussion_r849804783


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/orc/VectorizedReadUtils.java:
##########
@@ -160,8 +161,9 @@ public static void handleIcebergProjection(FileScanTask task, JobConf job, TypeD
     job.set(ColumnProjectionUtils.ORC_SCHEMA_STRING, readOrcSchema.toString());
 
     // Predicate pushdowns needs to be adjusted too in case of column renames, we let Iceberg generate this into job
-    if (task.residual() != null) {
-      Expression boundFilter = Binder.bind(currentSchema.asStruct(), task.residual(), false);
+    Expression residual = HiveIcebergInputFormat.residualForTask(task, job);
+    if (residual != null) {

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org