You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Hector Acosta (Code Review)" <ge...@cloudera.org> on 2019/03/26 21:13:40 UTC
[native-toolchain-CR] Prepend docker image to both stderr and stdout
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12861
Change subject: Prepend docker image to both stderr and stdout
......................................................................
Prepend docker image to both stderr and stdout
Sometimes, it may be hard to debug which distro produced an error, this
commit ensures that both stderr and stdout get piped through sed.
Change-Id: I16dd725b0c98599867892801c7146c4fe60f46e1
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/61/12861/1
--
To view, visit http://gerrit.cloudera.org:8080/12861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16dd725b0c98599867892801c7146c4fe60f46e1
Gerrit-Change-Number: 12861
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
[native-toolchain-CR] Prepend docker image to both stderr and stdout
Posted by "Hector Acosta (Code Review)" <ge...@cloudera.org>.
Hector Acosta has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12861 )
Change subject: Prepend docker image to both stderr and stdout
......................................................................
Prepend docker image to both stderr and stdout
Sometimes, it may be hard to debug which distro produced an error, this
commit ensures that both stderr and stdout get piped through sed.
Change-Id: I16dd725b0c98599867892801c7146c4fe60f46e1
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/61/12861/2
--
To view, visit http://gerrit.cloudera.org:8080/12861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I16dd725b0c98599867892801c7146c4fe60f46e1
Gerrit-Change-Number: 12861
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
[native-toolchain-CR] Prepend docker image to both stderr and stdout
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12861 )
Change subject: Prepend docker image to both stderr and stdout
......................................................................
Prepend docker image to both stderr and stdout
Sometimes, it may be hard to debug which distro produced an error, this
commit ensures that both stderr and stdout get piped through sed.
Change-Id: I16dd725b0c98599867892801c7146c4fe60f46e1
Reviewed-on: http://gerrit.cloudera.org:8080/12861
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I16dd725b0c98599867892801c7146c4fe60f46e1
Gerrit-Change-Number: 12861
Gerrit-PatchSet: 3
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] Prepend docker image to both stderr and stdout
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12861 )
Change subject: Prepend docker image to both stderr and stdout
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16dd725b0c98599867892801c7146c4fe60f46e1
Gerrit-Change-Number: 12861
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Apr 2019 16:08:44 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Prepend docker image to both stderr and stdout
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12861 )
Change subject: Prepend docker image to both stderr and stdout
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16dd725b0c98599867892801c7146c4fe60f46e1
Gerrit-Change-Number: 12861
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Apr 2019 16:08:49 +0000
Gerrit-HasComments: No