You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2020/12/15 21:29:05 UTC

[GitHub] [karaf] mdonkers opened a new pull request #1269: [KARAF-6963] First send SIGTERM, only SIGKILL if not shutting down nicely

mdonkers opened a new pull request #1269:
URL: https://github.com/apache/karaf/pull/1269


   Try first a regular `SIGTERM` to shutdown the daemon process.
   If that doesn't result in the process stopping within 10 seconds, follow with the `SIGKILL` signal.
   
   It's verifying in 1 second intervals whether the process is still running, so that the 'stop' request won't be blocking too long.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] mdonkers commented on pull request #1269: [KARAF-6963] First send SIGTERM, only SIGKILL if not shutting down nicely

Posted by GitBox <gi...@apache.org>.
mdonkers commented on pull request #1269:
URL: https://github.com/apache/karaf/pull/1269#issuecomment-781654902


   *Bump*.
   I haven't seen any updates. I think the build error is not correct or at least not related to this change, but cannot re-trigger.
   Would be nice if I could get some feedback, to move this forward.
   Many thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] jbonofre merged pull request #1269: [KARAF-6963] First send SIGTERM, only SIGKILL if not shutting down nicely

Posted by GitBox <gi...@apache.org>.
jbonofre merged pull request #1269:
URL: https://github.com/apache/karaf/pull/1269


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] mdonkers commented on pull request #1269: [KARAF-6963] First send SIGTERM, only SIGKILL if not shutting down nicely

Posted by GitBox <gi...@apache.org>.
mdonkers commented on pull request #1269:
URL: https://github.com/apache/karaf/pull/1269#issuecomment-746065457


   Rebundling our code with Karaf and with this fix applied, the exit status is now 'clean':
   
   ```
   root@vagrant:/opt/instana# systemctl stop instana-agent
   root@vagrant:/opt/instana# systemctl status instana-agent
   ● instana-agent.service - "Instana(tm) agent."
      Loaded: loaded (/lib/systemd/system/instana-agent.service; enabled; vendor preset: enabled)
      Active: inactive (dead) since Wed 2020-12-16 10:27:35 UTC; 3s ago
     Process: 14272 ExecStop=/opt/instana/agent/bin/karaf stop (code=exited, status=0/SUCCESS)
     Process: 14180 ExecStart=/opt/instana/agent/bin/karaf daemon (code=exited, status=0/SUCCESS)
    Main PID: 14180 (code=exited, status=0/SUCCESS)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [karaf] jbonofre commented on pull request #1269: [KARAF-6963] First send SIGTERM, only SIGKILL if not shutting down nicely

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1269:
URL: https://github.com/apache/karaf/pull/1269#issuecomment-791877606


   Thanks for the PR. I'm reviewing it now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org