You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/14 18:43:13 UTC
[GitHub] [arrow] lafiona opened a new pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function
lafiona opened a new pull request #12424:
URL: https://github.com/apache/arrow/pull/12424
## Overview
The MATLAB Interface to Arrow contains a [MEX](https://mathworks.com/help/matlab/call-mex-files-1.html?s_tid=CRUX_lftnav) function named `mexfcn` to delegate MATLAB calls to C++ functions that implement the functionality.
When the interface is installed, the name of the MEX function, `mexfcn`, is on the global [MATLAB Search Path](https://mathworks.com/help/matlab/matlab_env/what-is-the-matlab-search-path.html). Because the previous name only captured that it is related to MEX functionality, it may cause conflicts with functions outside of the MATLAB Interface to Arrow.
## Implementation
The following changes were made to address the potential naming conflict:
- Rename the MEX function to `call`.
- The name of the MEX file will be: `call.<mex-extension>`
- Install the MEX function to the MATLAB package folder hierarchy: `+arrow/+cpp` within the installation directory.
- Within MATLAB, the function is accessed by the following function signature: `arrow.cpp.call('<cpp-function-name>', <cpp-function-argument-1>, ..., <cpp-function-argument-N>)`.
- Install all dependencies of the MEX function to the same package folder hierarchy.
- Updated MATLAB tests to use the new function name.
## Testing
- The change was qualified locally on Windows 10 (Ninja and Visual Studio), macOS 11.5 (Ninja and Xcode) for the following configurations:
- Build both Arrow and GTest.
- Use `ARROW_HOME` and `GTEST_ROOT`.
- Additionally, the GitHub Actions CI passed for the change on Linux and macOS.
## Notes
Thank you for working on this pull request with me, @kevingurney!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#issuecomment-1039428158
https://issues.apache.org/jira/browse/ARROW-15650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#issuecomment-1057626937
Benchmark runs are scheduled for baseline = e989fb3f47b0c1190ab1bb98e4223898c6fd5962 and contender = 93b192c7a6ea9ca2d363cd9a345e678915cb3020. 93b192c7a6ea9ca2d363cd9a345e678915cb3020 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5a54ca80e49642a19099cdd5a9481830...3985081b77d54a04b6bbef15b33840c7/)
[Finished :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/dde8197a7bf84527a98f4a28e752cec9...0429758b21e54b4fa55d85a6fe0178ca/)
[Finished :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/aaf6c94481404fd5b6f30dee254b6c5f...42bb2b6ea78f47e7abf12b36bc1a2bc3/)
[Finished :arrow_down:0.3% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1ea03e1b871d4d83ae99273bedb399ac...54ff6417e26c4fe28183224e4369ca65/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#issuecomment-1057531382
Can we merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#issuecomment-1057626937
Benchmark runs are scheduled for baseline = e989fb3f47b0c1190ab1bb98e4223898c6fd5962 and contender = 93b192c7a6ea9ca2d363cd9a345e678915cb3020. 93b192c7a6ea9ca2d363cd9a345e678915cb3020 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5a54ca80e49642a19099cdd5a9481830...3985081b77d54a04b6bbef15b33840c7/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/dde8197a7bf84527a98f4a28e752cec9...0429758b21e54b4fa55d85a6fe0178ca/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/aaf6c94481404fd5b6f30dee254b6c5f...42bb2b6ea78f47e7abf12b36bc1a2bc3/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1ea03e1b871d4d83ae99273bedb399ac...54ff6417e26c4fe28183224e4369ca65/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#issuecomment-1057626937
Benchmark runs are scheduled for baseline = e989fb3f47b0c1190ab1bb98e4223898c6fd5962 and contender = 93b192c7a6ea9ca2d363cd9a345e678915cb3020. 93b192c7a6ea9ca2d363cd9a345e678915cb3020 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5a54ca80e49642a19099cdd5a9481830...3985081b77d54a04b6bbef15b33840c7/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/dde8197a7bf84527a98f4a28e752cec9...0429758b21e54b4fa55d85a6fe0178ca/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/aaf6c94481404fd5b6f30dee254b6c5f...42bb2b6ea78f47e7abf12b36bc1a2bc3/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1ea03e1b871d4d83ae99273bedb399ac...54ff6417e26c4fe28183224e4369ca65/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nickhaddady commented on a change in pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function
Posted by GitBox <gi...@apache.org>.
nickhaddady commented on a change in pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#discussion_r806215678
##########
File path: matlab/CMakeLists.txt
##########
@@ -305,16 +305,17 @@ target_include_directories(arrow_matlab PRIVATE ${CPP_SOURCE_DIR})
target_include_directories(arrow_matlab PRIVATE ${ARROW_INCLUDE_DIR})
target_compile_definitions(arrow_matlab PRIVATE ARROW_MATLAB_EXPORTING)
-set(mexfcn_sources mex/mexfcn.cc)
-list(TRANSFORM mexfcn_sources PREPEND ${CPP_SOURCE_DIR}/arrow/matlab/)
+set(mexcall_sources mex/call.cc)
+list(TRANSFORM mexcall_sources PREPEND ${CPP_SOURCE_DIR}/arrow/matlab/)
-# Build mexfcn MEX binary.
+# Build call MEX binary.
matlab_add_mex(R2018a
- NAME mexfcn
- SRC ${mexfcn_sources}
+ NAME mexcall
Review comment:
Will the name of shared library here end up being mexcall.so or mexcall.dll? Since mex files are shared libraries, and they need to be unique on some platforms (namely linux) to avoid symbol collisions. mexcall is still fairly generic.
I would consider something more obfuscated like mlarrowmexcall.so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#issuecomment-1039428158
https://issues.apache.org/jira/browse/ARROW-15650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lafiona commented on a change in pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function [WIP]
Posted by GitBox <gi...@apache.org>.
lafiona commented on a change in pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#discussion_r806280978
##########
File path: matlab/CMakeLists.txt
##########
@@ -305,16 +305,17 @@ target_include_directories(arrow_matlab PRIVATE ${CPP_SOURCE_DIR})
target_include_directories(arrow_matlab PRIVATE ${ARROW_INCLUDE_DIR})
target_compile_definitions(arrow_matlab PRIVATE ARROW_MATLAB_EXPORTING)
-set(mexfcn_sources mex/mexfcn.cc)
-list(TRANSFORM mexfcn_sources PREPEND ${CPP_SOURCE_DIR}/arrow/matlab/)
+set(mexcall_sources mex/call.cc)
+list(TRANSFORM mexcall_sources PREPEND ${CPP_SOURCE_DIR}/arrow/matlab/)
-# Build mexfcn MEX binary.
+# Build call MEX binary.
matlab_add_mex(R2018a
- NAME mexfcn
- SRC ${mexfcn_sources}
+ NAME mexcall
Review comment:
Thank you for your feedback, Nick! That's a great point that you have brought up: even though the MATLAB API for calling the MEX function will be unique, as it is within a package, the shared library that is loaded may have a conflict. I will look into a solution for this and submit it to this branch (marking the branch as [WIP] for now).
Since we want to keep the API as clean as possible, it may be effective to wrap the MEX function with a MATLAB function that calls the more obfuscated name. This will also provide an opportunity to validate function arguments before passing them to the MEX layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lafiona commented on a change in pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function [WIP]
Posted by GitBox <gi...@apache.org>.
lafiona commented on a change in pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#discussion_r806280978
##########
File path: matlab/CMakeLists.txt
##########
@@ -305,16 +305,17 @@ target_include_directories(arrow_matlab PRIVATE ${CPP_SOURCE_DIR})
target_include_directories(arrow_matlab PRIVATE ${ARROW_INCLUDE_DIR})
target_compile_definitions(arrow_matlab PRIVATE ARROW_MATLAB_EXPORTING)
-set(mexfcn_sources mex/mexfcn.cc)
-list(TRANSFORM mexfcn_sources PREPEND ${CPP_SOURCE_DIR}/arrow/matlab/)
+set(mexcall_sources mex/call.cc)
+list(TRANSFORM mexcall_sources PREPEND ${CPP_SOURCE_DIR}/arrow/matlab/)
-# Build mexfcn MEX binary.
+# Build call MEX binary.
matlab_add_mex(R2018a
- NAME mexfcn
- SRC ${mexfcn_sources}
+ NAME mexcall
Review comment:
Thank you for your feedback, Nick! That's a great point that you have brought up: even though the MATLAB API for calling the MEX function will be unique, as it is within a package, the shared library that is loaded may have a conflict. I will look into a solution for this and submit it to this branch (marking the branch as [WIP] for now).
Since we want to keep the API as clean as possible, it may be effective to wrap the MEX function with a MATLAB function that calls the more obfuscated name. This will also provide an opportunity to validate function arguments before passing them to the MEX layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lafiona commented on a change in pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function [WIP]
Posted by GitBox <gi...@apache.org>.
lafiona commented on a change in pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#discussion_r810334081
##########
File path: matlab/CMakeLists.txt
##########
@@ -305,16 +305,17 @@ target_include_directories(arrow_matlab PRIVATE ${CPP_SOURCE_DIR})
target_include_directories(arrow_matlab PRIVATE ${ARROW_INCLUDE_DIR})
target_compile_definitions(arrow_matlab PRIVATE ARROW_MATLAB_EXPORTING)
-set(mexfcn_sources mex/mexfcn.cc)
-list(TRANSFORM mexfcn_sources PREPEND ${CPP_SOURCE_DIR}/arrow/matlab/)
+set(mexcall_sources mex/call.cc)
+list(TRANSFORM mexcall_sources PREPEND ${CPP_SOURCE_DIR}/arrow/matlab/)
-# Build mexfcn MEX binary.
+# Build call MEX binary.
matlab_add_mex(R2018a
- NAME mexfcn
- SRC ${mexfcn_sources}
+ NAME mexcall
Review comment:
After some investigation, I found that MATLAB performs runtime dynamic linking for MEX functions, and that they are loaded using their full filename, including the full path. This means that MATLAB is able to differentiate between two MEX functions, of the same name, as long as the MEX shared libraries are in different directories.
I tested this behavior by creating two parallel packages containing MEX files with the same name and different contents. After compiling both, I could access both in the same instance of MATLAB, on Windows, macOS, and Linux.
The name of the MEX shared library in this case is `call.<mex-extension>`. There should not be any collisions because there cannot be another MEX file with the same name, in the same package.
In the future, there are opportunities to wrap the MEX function in M-code to improve the API and enable input argument validation and logging as the supported functionality expands.
I will mark the Pull Request as "ready", however, please let me know if you still have any concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#issuecomment-1057623849
OK.
Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nickhaddady commented on a change in pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function
Posted by GitBox <gi...@apache.org>.
nickhaddady commented on a change in pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#discussion_r806215678
##########
File path: matlab/CMakeLists.txt
##########
@@ -305,16 +305,17 @@ target_include_directories(arrow_matlab PRIVATE ${CPP_SOURCE_DIR})
target_include_directories(arrow_matlab PRIVATE ${ARROW_INCLUDE_DIR})
target_compile_definitions(arrow_matlab PRIVATE ARROW_MATLAB_EXPORTING)
-set(mexfcn_sources mex/mexfcn.cc)
-list(TRANSFORM mexfcn_sources PREPEND ${CPP_SOURCE_DIR}/arrow/matlab/)
+set(mexcall_sources mex/call.cc)
+list(TRANSFORM mexcall_sources PREPEND ${CPP_SOURCE_DIR}/arrow/matlab/)
-# Build mexfcn MEX binary.
+# Build call MEX binary.
matlab_add_mex(R2018a
- NAME mexfcn
- SRC ${mexfcn_sources}
+ NAME mexcall
Review comment:
Will the name of shared library here end up being mexcall.so or mexcall.dll? Since mex files are shared libraries, and they need to be unique on some platforms (namely linux) to avoid symbol collisions. mexcall is still fairly generic.
I would consider something more obfuscated like mlarrowmexcall.so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#issuecomment-1057626937
Benchmark runs are scheduled for baseline = e989fb3f47b0c1190ab1bb98e4223898c6fd5962 and contender = 93b192c7a6ea9ca2d363cd9a345e678915cb3020. 93b192c7a6ea9ca2d363cd9a345e678915cb3020 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5a54ca80e49642a19099cdd5a9481830...3985081b77d54a04b6bbef15b33840c7/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/dde8197a7bf84527a98f4a28e752cec9...0429758b21e54b4fa55d85a6fe0178ca/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/aaf6c94481404fd5b6f30dee254b6c5f...42bb2b6ea78f47e7abf12b36bc1a2bc3/)
[Finished :arrow_down:0.3% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1ea03e1b871d4d83ae99273bedb399ac...54ff6417e26c4fe28183224e4369ca65/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#issuecomment-1057626937
Benchmark runs are scheduled for baseline = e989fb3f47b0c1190ab1bb98e4223898c6fd5962 and contender = 93b192c7a6ea9ca2d363cd9a345e678915cb3020. 93b192c7a6ea9ca2d363cd9a345e678915cb3020 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5a54ca80e49642a19099cdd5a9481830...3985081b77d54a04b6bbef15b33840c7/)
[Finished :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/dde8197a7bf84527a98f4a28e752cec9...0429758b21e54b4fa55d85a6fe0178ca/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/aaf6c94481404fd5b6f30dee254b6c5f...42bb2b6ea78f47e7abf12b36bc1a2bc3/)
[Finished :arrow_down:0.3% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/1ea03e1b871d4d83ae99273bedb399ac...54ff6417e26c4fe28183224e4369ca65/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lafiona commented on pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function
Posted by GitBox <gi...@apache.org>.
lafiona commented on pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#issuecomment-1039465060
@nickhaddady, do you have any feedback for this design change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lafiona commented on pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function
Posted by GitBox <gi...@apache.org>.
lafiona commented on pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#issuecomment-1039465060
@nickhaddady, do you have any feedback for this design change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lafiona commented on pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function
Posted by GitBox <gi...@apache.org>.
lafiona commented on pull request #12424:
URL: https://github.com/apache/arrow/pull/12424#issuecomment-1057571365
> Can we merge this?
Yes, this is ready to merge. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #12424: ARROW-15650: [MATLAB] Rename the MEX gateway function
Posted by GitBox <gi...@apache.org>.
kou closed pull request #12424:
URL: https://github.com/apache/arrow/pull/12424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org