You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/23 09:07:04 UTC

[GitHub] [rocketmq-clients] aaron-ai commented on a diff in pull request #323: Add missing unsubscribe in SimpleConsumer, Addresses #305

aaron-ai commented on code in PR #323:
URL: https://github.com/apache/rocketmq-clients/pull/323#discussion_r1056162364


##########
csharp/rocketmq-client-csharp/MetadataConstants.cs:
##########
@@ -37,5 +38,10 @@ public class MetadataConstants
         public const string REQUEST_ID_KEY = "x-mq-request-id";
 
         public const string CLIENT_ID_KEY = "x-mq-client-id";
+
+        public static readonly string CLIENT_VERSION = Assembly

Review Comment:
   Nice! we shoud try to get version from predefined one from csproj.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org