[jira] [Work logged] (CURATOR-546) currentData in ModeledCacheImpl removes ZPath from cache entries

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CURATOR-546?focusedWorklogId=326708&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-326708 ]

ASF GitHub Bot logged work on CURATOR-546:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Oct/19 05:27
            Start Date: 11/Oct/19 05:27
    Worklog Time Spent: 10m 
      Work Description: Randgalt commented on pull request #329: [CURATOR-546] - ModeledCacheImpl.currentData() was removing from entries instead of calling get()
URL: https://github.com/apache/curator/pull/329
 
 
   Bad copy/paste bug. ModeledCacheImpl.currentData() was removing from entries instead of calling get()
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 326708)
    Remaining Estimate: 0h
            Time Spent: 10m

> currentData in ModeledCacheImpl removes ZPath from cache entries 
> -----------------------------------------------------------------
>
>                 Key: CURATOR-546
>                 URL: https://issues.apache.org/jira/browse/CURATOR-546
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Client, Framework
>    Affects Versions: 4.2.0
>            Reporter: Yang
>            Priority: Blocker
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I'm using AsyncCuratorFramework with cache, during testing I noticed that 
> *client.cache().currentChildren(<zkPath>)* not also return the full list of children, by digging into *ModeledCacheImpl*, apparently some children been deleted when I call *client.cache().currentData(<zkPath>)*. 
> What's the alternative for me if I wants to get cached node while don't remove it from the cache? 
>  
> public Optional<ZNode<T>> currentData(ZPath path)
>  {
>  Entry<T> entry = entries.remove(path);
>  if ( entry != null )
> { return Optional.of(new ZNodeImpl<>(path, entry.stat, entry.model)); }
> return Optional.empty();
>  }
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)