[GitHub] [airflow] turbaszek commented on a change in pull request #21267: Dataproc metastore assets

[GitBox <gi...@apache.org>]

turbaszek commented on a change in pull request #21267:
URL: https://github.com/apache/airflow/pull/21267#discussion_r800086099



##########
File path: airflow/providers/google/cloud/operators/dataproc_metastore.py
##########
@@ -340,6 +492,11 @@ def execute(self, context: 'Context') -> dict:
                 timeout=self.timeout,
                 metadata=self.metadata,
             )
+        self.xcom_push(
+            context,
+            key="service_conf",
+            value={"region": self.region, "service_id": self.service_id, "project_id": self.project_id},
+        )

Review comment:
       I'm wondering if it would make sense to add class/static method on operator link to handle this logic? Something like:
   ```py
   DataprocMetastoreServiceLink.persist(task_instance=self)
   ```
   Why? First this make it more obvious why we save this XCom (to use it in link), second it somehow nicely encapsulates the logic into link class. WDYT? CC @potiuk @josh-fell 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org