[GitHub] [helix] jiajunwang commented on pull request #2478: Add hashCode() to AssignableReplica and fix logic in hash-based collection

["jiajunwang (via GitHub)" <gi...@apache.org>]

jiajunwang commented on PR #2478:
URL: https://github.com/apache/helix/pull/2478#issuecomment-1535588989

   I had tried this when WAGED is firstly developed. What I can tell is that performance will be terrible and the rebalancer basically unusable in middle to large size clusters.
   
   And to be complete, I also tried to add a hashcode then using a map with item counts as value. I remember the speed is better, but not good enough for production usage.
   
   Do we have any logic fails that makes you believe we should add hashcode back? I mean what's the real problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org