You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by kylerichardson <gi...@git.apache.org> on 2016/12/02 03:00:33 UTC
[GitHub] incubator-metron pull request #384: METRON-603 Update website to use Apache ...
GitHub user kylerichardson opened a pull request:
https://github.com/apache/incubator-metron/pull/384
METRON-603 Update website to use Apache release repo
Update the DOWNLOAD link on the navigation menu of the website to point to the Apache release repository.
Verified site by following instructions on wiki [1].
NOTE: I'm holding off committing my recent PR (#382) to asf-site until this is fully merged to ensure consistency on the website.
[1] https://cwiki.apache.org/confluence/display/METRON/Website+PR+Merge
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kylerichardson/incubator-metron METRON-603
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-metron/pull/384.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #384
----
commit 63da11df5ba29390aa3352f4dbf50985dc3d3a49
Author: kylerichardson <ky...@gmail.com>
Date: 2016-12-02T02:50:36Z
METRON-603 Update website download links to use apache release repo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #384: METRON-603 Update website to use Apache ...
Posted by kylerichardson <gi...@git.apache.org>.
Github user kylerichardson closed the pull request at:
https://github.com/apache/incubator-metron/pull/384
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #384: METRON-603 Update website to use Apache ...
Posted by kylerichardson <gi...@git.apache.org>.
Github user kylerichardson commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/384#discussion_r90926228
--- Diff: site/_includes/primary-nav-items.html ---
@@ -10,6 +10,6 @@
<li class="training-menu"><a href="/news/">News</a>
</li>
<li>
- <button class="button-default button-green trigger-top-form"> <a href="https://github.com/apache/incubator-metron/releases" target="new">Download </a></button>
+ <button class="button-default button-green trigger-top-form"> <a href="https://dist.apache.org/repos/dist/release/incubator/metron/" target="new">Download </a></button>
--- End diff --
@cestella Wow, looks like I need to do my homework a little better :). Thanks! I'll close this out as well as the associated JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #384: METRON-603 Update website to use Apache ...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/384#discussion_r90925604
--- Diff: site/_includes/primary-nav-items.html ---
@@ -10,6 +10,6 @@
<li class="training-menu"><a href="/news/">News</a>
</li>
<li>
- <button class="button-default button-green trigger-top-form"> <a href="https://github.com/apache/incubator-metron/releases" target="new">Download </a></button>
+ <button class="button-default button-green trigger-top-form"> <a href="https://dist.apache.org/repos/dist/release/incubator/metron/" target="new">Download </a></button>
--- End diff --
@kylerichardson actually, I think #373 should cover it. That was the PR created after I made the urgent change. Let me commit that real quick.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #384: METRON-603 Update website to use Apache ...
Posted by mattf-horton <gi...@git.apache.org>.
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/384#discussion_r90739762
--- Diff: site/_includes/primary-nav-items.html ---
@@ -10,6 +10,6 @@
<li class="training-menu"><a href="/news/">News</a>
</li>
<li>
- <button class="button-default button-green trigger-top-form"> <a href="https://github.com/apache/incubator-metron/releases" target="new">Download </a></button>
+ <button class="button-default button-green trigger-top-form"> <a href="https://dist.apache.org/repos/dist/release/incubator/metron/" target="new">Download </a></button>
--- End diff --
@kylerichardson , I agree, a downloads page is more or less the only way to satisfy the simultaneous requirements of directing the code download through a mirror and the signature download through the dist site.
I would suggest keeping jira METRON-603 open (adding "via Mirror script" to the title) and using it for the correct enhancement later on. Meanwhile, I have no objection to committing this PR as an improvement to the current situation of having the actual site out of sync with the source code. We are still sufficiently low volume that we aren't likely to cause problems with Infra.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #384: METRON-603 Update website to use Apache ...
Posted by cestella <gi...@git.apache.org>.
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/384#discussion_r90921640
--- Diff: site/_includes/primary-nav-items.html ---
@@ -10,6 +10,6 @@
<li class="training-menu"><a href="/news/">News</a>
</li>
<li>
- <button class="button-default button-green trigger-top-form"> <a href="https://github.com/apache/incubator-metron/releases" target="new">Download </a></button>
+ <button class="button-default button-green trigger-top-form"> <a href="https://dist.apache.org/repos/dist/release/incubator/metron/" target="new">Download </a></button>
--- End diff --
Just FYI, METRON-600 was created to capture the website changes that need to happen. That commit was to get around an immediate and urgent issue with the download link (namely, it was pointing to github which hosted non-apache released artifacts). METRON-600 is intended to fix the website with a proper download page (among other things).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #384: METRON-603 Update website to use Apache ...
Posted by mattf-horton <gi...@git.apache.org>.
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/384#discussion_r90947064
--- Diff: site/_includes/primary-nav-items.html ---
@@ -10,6 +10,6 @@
<li class="training-menu"><a href="/news/">News</a>
</li>
<li>
- <button class="button-default button-green trigger-top-form"> <a href="https://github.com/apache/incubator-metron/releases" target="new">Download </a></button>
+ <button class="button-default button-green trigger-top-form"> <a href="https://dist.apache.org/repos/dist/release/incubator/metron/" target="new">Download </a></button>
--- End diff --
It looks like METRON-600 is now the correct place to state the need for a Downloads page to support the mirroring requirement. I will add it there, so suggest you go ahead and close METRON-603.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #384: METRON-603 Update website to use Apache ...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/384#discussion_r90726311
--- Diff: site/_includes/primary-nav-items.html ---
@@ -10,6 +10,6 @@
<li class="training-menu"><a href="/news/">News</a>
</li>
<li>
- <button class="button-default button-green trigger-top-form"> <a href="https://github.com/apache/incubator-metron/releases" target="new">Download </a></button>
+ <button class="button-default button-green trigger-top-form"> <a href="https://dist.apache.org/repos/dist/release/incubator/metron/" target="new">Download </a></button>
--- End diff --
@kylerichardson A separate downloads page a good approach that a lot of projects take.
Basically you have links to the source/binary artifacts that go through closer.cgi, and the links to the checksums/signatures go to dist.apache.org. The reason behind that is that checksums/signatures are not synced with the mirrors for security reasons.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-metron pull request #384: METRON-603 Update website to use Apache ...
Posted by mattf-horton <gi...@git.apache.org>.
Github user mattf-horton commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/384#discussion_r90615484
--- Diff: site/_includes/primary-nav-items.html ---
@@ -10,6 +10,6 @@
<li class="training-menu"><a href="/news/">News</a>
</li>
<li>
- <button class="button-default button-green trigger-top-form"> <a href="https://github.com/apache/incubator-metron/releases" target="new">Download </a></button>
+ <button class="button-default button-green trigger-top-form"> <a href="https://dist.apache.org/repos/dist/release/incubator/metron/" target="new">Download </a></button>
--- End diff --
Hi Kyle, this change is on the right path, since we definitely should be publishing downloads on "dist". However, http://www.apache.org/dev/release-download-pages.html says:
- All links to the distribution artifacts **must not** reference the main Apache web site ["dist"]. They should use the standard mechanisms to distribute the load between the mirror sites [see http://www.apache.org/dyn/closer.cgi/ ].
- All links to checksums, detached signatures and public keys **must** reference the main Apache web site and should use https (SSL).
The web page then goes on in some detail about how to set up a script to automatically redirect the user to an appropriate mirror.
If the above isn't clear, there is a better written explanation at http://incubator.apache.org/guides/releasemanagement.html#understanding-mirroring
But it points back to http://www.apache.org/dev/release-download-pages.html to talk about the script.
An example of a good download page that uses an automatic mirror-direction script is
https://maven.apache.org/download.cgi
An example of a download page that is "dumber" but therefore easier to set up is
https://hadoop.apache.org/releases.html
The quick-and-dirty fix is to simply point at http://www.apache.org/dyn/closer.cgi/incubator/metron/ instead of
https://dist.apache.org/repos/dist/release/incubator/metron/ , BUT that doesn't give the user access to the secure signatures, and that's not acceptable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---