You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/09/24 01:42:55 UTC

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1578: Python SessionUT added

HTHou commented on a change in pull request #1578:
URL: https://github.com/apache/incubator-iotdb/pull/1578#discussion_r493989828



##########
File path: importerCSV-py/src/utils/Field.py
##########
@@ -0,0 +1,158 @@
+from IoTDBConstants import TSDataType
+
+
+class Field(object):

Review comment:
       This file is missing Apache header, please take a look.

##########
File path: importerCSV-py/src/utils/IoTDBRpcDataSet.py
##########
@@ -0,0 +1,203 @@
+import sys
+from IoTDBConstants import *
+sys.path.append("../../target")
+
+from thrift.transport import TSocket, TTransport

Review comment:
       Same..

##########
File path: importerCSV-py/src/utils/Tablet.py
##########
@@ -0,0 +1,116 @@
+
+from IoTDBConstants import *
+import struct
+
+

Review comment:
       Same

##########
File path: importerCSV-py/src/utils/RowRecord.py
##########
@@ -0,0 +1,37 @@
+from IoTDBConstants import TSDataType
+from Field import Field
+
+
+class RowRecord(object):
+

Review comment:
       Same

##########
File path: importerCSV-py/src/utils/IoTDBConstants.py
##########
@@ -0,0 +1,35 @@
+
+from enum import Enum, unique
+
+
+@unique

Review comment:
       Same as above.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org