[GitHub] zhijiangW opened a new pull request #6809: [FLINK-10491][network] Pass BufferPoolOwner in the constructor of LocalBufferPool

[GitBox <gi...@apache.org>]

zhijiangW opened a new pull request #6809: [FLINK-10491][network] Pass BufferPoolOwner in the constructor of LocalBufferPool
URL: https://github.com/apache/flink/pull/6809
 
 
   ## What is the purpose of the change
   
   *The `BufferPoolOwner` can be passed in the constructor of `LocalBufferPool` instead of a separate method for setting it. To do so, we can make this variable as final to become easy and safe.
   
   BTW, we can also reduce the synchronized zone in the method of `LocalBufferPool#setNumBuffers` which may cause deadlock in special cases.*
   
   ## Brief change log
   
     - *Pass `BufferPoolOwner` in constructor of `LocalBufferPool` and remove the `setBufferPoolOwner` method*
     - *Make `owner#releaseMemory` outside of syn part in `setNumBuffers`*
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services