[GitHub] [samza] rmatharu commented on a change in pull request #1055: SAMZA-2227 : Fix to ensure that new topics detected by regex-monitor are picked up during next deployment of app

[GitBox <gi...@apache.org>]

rmatharu commented on a change in pull request #1055: SAMZA-2227 : Fix to ensure that new topics detected by regex-monitor are picked up during next deployment of app
URL: https://github.com/apache/samza/pull/1055#discussion_r288781215
 
 

 ##########
 File path: samza-core/src/main/scala/org/apache/samza/config/RegExTopicGenerator.scala
 ##########
 @@ -97,19 +95,13 @@ class RegExTopicGenerator extends ConfigRewriter with Logging {
     new MapConfig(((keysAndValsToAdd ++ config.asScala) += inputStreams).asJava)
   }
 
-  def getTopicsFromZK(rewriterName: String, config: Config): Seq[String] = {
-    val systemName = config
+  def getTopicsFromStreamMetadataCache(rewriterName: String, config: Config): Seq[String] = {
 
 Review comment:
   Its neccessary because it allows the regex-expansion to be Kafka-agnostic, which allows the regexGenerator to be moved to samza-core (so that the job-model-manager can invoke it). 
   
   Currently, the regexGenerator is in samza-kafka, so the job-model-manager cannot invoke the regexGenerator, without adding a dependency (circular) from samza-core to samza-kafka. 
   Also, reading topic info from Zk without using a documented API, bypassing the broker, seems kinda rakish.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services