You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/07 21:26:44 UTC
[GitHub] [airflow] jhtimmins opened a new pull request #16865: Use existing cached_property method to skip pylint error.
jhtimmins opened a new pull request #16865:
URL: https://github.com/apache/airflow/pull/16865
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on pull request #16865: Use existing cached_property method to skip pylint error.
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #16865:
URL: https://github.com/apache/airflow/pull/16865#issuecomment-875951013
@potiuk yeah it's trying to import from a file that doesn't exist without your pylint PR. So rather than merge in that PR now, I'm just having it reference the `cached_property` method from before your pylint chAnages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #16865: Use existing cached_property method to skip pylint error.
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #16865:
URL: https://github.com/apache/airflow/pull/16865#issuecomment-875954489
BTW. Those are not my pylint changes - the actual reason for that error is the https://github.com/apache/airflow/pull/15969 which introduced the compat shim (and that's the one that is missing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16865: Use existing cached_property method to skip pylint error.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16865:
URL: https://github.com/apache/airflow/pull/16865#issuecomment-875948214
The #16682 cherry-picking might be faster way :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16865: Use existing cached_property method to skip pylint error.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16865:
URL: https://github.com/apache/airflow/pull/16865#issuecomment-875949715
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16865: Use existing cached_property method to skip pylint error.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16865:
URL: https://github.com/apache/airflow/pull/16865#issuecomment-875954489
BTW. Those are not my pylint changes - the actual reason for that error is the https://github.com/apache/airflow/pull/15969 which introduced the compat shim
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #16865: Use existing cached_property method to skip pylint error.
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #16865:
URL: https://github.com/apache/airflow/pull/16865#issuecomment-875952706
Yeah. I see - simply so far we usually solved those kind of problems by bringing-in all missing commits (@ashb even had a magic git command to get the chain of commits needed). But it has some drawbacks (bringing more than needed sometimes. Just for consideration., I think bringing some refactors/tool commits make it more future-proof and easier to cherry-pick subsequent fixes if needed. I don't mind either, but I think final result is better if we mostly stick to cherry-picking rather than fixing in-place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16865: Use existing cached_property method to skip pylint error.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16865:
URL: https://github.com/apache/airflow/pull/16865#issuecomment-875952706
Yeah. I see - simply so far we usually solved those kind of problems by bringing-in all missing commits (@ashb even had a magic git command to get the chain of commits needed). But it has some drawbacks (bringing more than needed sometimes. Just for consideration., I think bringing some refactors/tool commts make it more future-proof and easier to cherry-pick subsequent fixes if needed. I don't mind either, but I think final resul is better if we mostly stick to cherry-picking rather than fixing in-place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins closed pull request #16865: Use existing cached_property method to skip pylint error.
Posted by GitBox <gi...@apache.org>.
jhtimmins closed pull request #16865:
URL: https://github.com/apache/airflow/pull/16865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org