[GitHub] [spark] Ngone51 commented on a change in pull request #26624: [SPARK-8981][core] Add MDC support in Executor

[GitBox <gi...@apache.org>]

Ngone51 commented on a change in pull request #26624:
URL: https://github.com/apache/spark/pull/26624#discussion_r415576971



##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -674,6 +677,18 @@ private[spark] class Executor(
     }
   }
 
+  private def setMDCForTask(taskDescription: TaskDescription): Unit = {
+    val properties = taskDescription.properties
+
+    org.slf4j.MDC.put("appId", properties.getProperty("spark.app.id"))
+    org.slf4j.MDC.put("appName", properties.getProperty("spark.app.name"))

Review comment:
       `taskDescription.properties` doesn't have these two attributes. We can try `taskDescription.name` firstly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org