You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2023/03/13 12:26:22 UTC
[GitHub] [superset] kgabryje opened a new pull request, #23347: fix(dashboard): Cross filters with time shifted series
kgabryje opened a new pull request, #23347:
URL: https://github.com/apache/superset/pull/23347
### SUMMARY
When user tried to use cross filtering on time shifted series, the cross filtering would take the time shift as a value rather than the series name. For example if user applied 1 year time shift on "gender" series and then applied cross filter on series "1 year ago, boy", it would emit filter `where gender in ['1 year ago']` instead of `where gender in ['boy']`.
This PR fixes that behaviour by removing time shifted series names from label map
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
1. Create a timeseries chart (for example Echarts Line chart with temporal x axis), add a groupby column, add a time shift
2. Add the chart to a dashboard and click on time shifted series to emit a cross filter
3. Verify that the emitted filter is correct
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #23347: fix(dashboard): Cross filters with time shifted series
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje merged PR #23347:
URL: https://github.com/apache/superset/pull/23347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23347: fix(dashboard): Cross filters with time shifted series
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23347:
URL: https://github.com/apache/superset/pull/23347#issuecomment-1466137185
## [Codecov](https://codecov.io/gh/apache/superset/pull/23347?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23347](https://codecov.io/gh/apache/superset/pull/23347?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4ae9476) into [master](https://codecov.io/gh/apache/superset/commit/a8d5cb89a8f35e01a8e420c89bc19a9f8b61aa45?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a8d5cb8) will **increase** coverage by `0.00%`.
> The diff coverage is `83.33%`.
> :exclamation: Current head 4ae9476 differs from pull request most recent head f5f6d9f. Consider uploading reports for the commit f5f6d9f to get more accurate results
```diff
@@ Coverage Diff @@
## master #23347 +/- ##
=======================================
Coverage 67.51% 67.51%
=======================================
Files 1909 1909
Lines 73465 73470 +5
Branches 7975 7977 +2
=======================================
+ Hits 49601 49606 +5
+ Misses 21816 21815 -1
- Partials 2048 2049 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.74% <83.33%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...gin-chart-echarts/src/Timeseries/transformProps.ts](https://codecov.io/gh/apache/superset/pull/23347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVGltZXNlcmllcy90cmFuc2Zvcm1Qcm9wcy50cw==) | `58.94% <83.33%> (+2.28%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org