You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/01/07 08:52:21 UTC

[GitHub] [calcite] rubenada commented on a change in pull request #2181: CALCITE-4264 Take CPU cost into account in VolcanoCost

rubenada commented on a change in pull request #2181:
URL: https://github.com/apache/calcite/pull/2181#discussion_r553187071



##########
File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoCost.java
##########
@@ -97,24 +97,25 @@
     return io;
   }
 
+  int compare(VolcanoCost other) {

Review comment:
       maybe this method should be private?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org