You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/30 22:16:12 UTC
[GitHub] [airflow] potiuk opened a new pull request #7299: [AIRFLOW-6687]
Switch kubernetes tests to example_dags
potiuk opened a new pull request #7299: [AIRFLOW-6687] Switch kubernetes tests to example_dags
URL: https://github.com/apache/airflow/pull/7299
The files were moved during AIP-21 and our tests do not run
kubernetes tests for optimisations that's why it's not been
noticed
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7299: [AIRFLOW-6687] Switch
kubernetes tests to example_dags
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7299: [AIRFLOW-6687] Switch kubernetes tests to example_dags
URL: https://github.com/apache/airflow/pull/7299#issuecomment-580487686
This should fix the problem with failing kubernetes builds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7299: [AIRFLOW-6687] Switch
kubernetes tests to example_dags
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7299: [AIRFLOW-6687] Switch kubernetes tests to example_dags
URL: https://github.com/apache/airflow/pull/7299#issuecomment-580598463
Merged it to see behaviour on master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7299: [AIRFLOW-6687] Switch
kubernetes tests to example_dags
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7299: [AIRFLOW-6687] Switch kubernetes tests to example_dags
URL: https://github.com/apache/airflow/pull/7299
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7299: [AIRFLOW-6687] Switch
kubernetes tests to example_dags
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7299: [AIRFLOW-6687] Switch kubernetes tests to example_dags
URL: https://github.com/apache/airflow/pull/7299#issuecomment-580489191
This error was super confusing because it behaves differently under different circumstances
There were three problems:
1) copying files was done from contrib/example_dags which is gone now
2) kubernetes tests are not executed when no kubernetes related files were changed - and we did not have the example_dags folder marked as "kubernetes-related"
3) kubernetes git-sync uses master of apache/airflow github repo - so it behave differently before/after merging to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services