You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Qin Liu <qi...@gmail.com> on 2017/02/13 19:22:19 UTC
Review Request 56603: AMBARI-19953: AMS HBase RegionServer process is
still alive after switching AMS to embedded mode
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56603/
-----------------------------------------------------------
Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle.
Bugs: AMBARI-19953
https://issues.apache.org/jira/browse/AMBARI-19953
Repository: ambari
Description
-------
After switching AMS to embedded mode, AMS HBase region server process from previous AMS configs is still alive.
Steps to reproduce:
1. install a cluster with AMS distributed mode
2. ps -elf | grep ams
3. switch AMS to embedded mode
4. restart AMS
5. ps -elf | grep ams and will see AMS HBase regionserver process from previous AMS distributed configs is still alive
The fix is when AMS is in embedded mode, make sure no residual region server process is running at collector stop.
Diffs
-----
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py f423165
ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py 7df74bf
Diff: https://reviews.apache.org/r/56603/diff/
Testing
-------
The fix has been tested via HDP UI.
The unit testcase test_metrics_collector.py has been updated to reflect the change.
Thanks,
Qin Liu
Re: Review Request 56603: AMBARI-19953: AMS HBase RegionServer
process is still alive after switching AMS to embedded mode
Posted by Aravindan Vijayan <av...@hortonworks.com>.
> On Feb. 13, 2017, 7:39 p.m., Aravindan Vijayan wrote:
> > Ship It!
>
> Qin Liu wrote:
> Thank you very much Aravindan!
>
> Qin Liu wrote:
> Hi Aravindan, I would really appreciate if you can commit the changes to trunk.
Done. please close this review.
- Aravindan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56603/#review165382
-----------------------------------------------------------
On Feb. 13, 2017, 7:22 p.m., Qin Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56603/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 7:22 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle.
>
>
> Bugs: AMBARI-19953
> https://issues.apache.org/jira/browse/AMBARI-19953
>
>
> Repository: ambari
>
>
> Description
> -------
>
> After switching AMS to embedded mode, AMS HBase region server process from previous AMS configs is still alive.
>
> Steps to reproduce:
> 1. install a cluster with AMS distributed mode
> 2. ps -elf | grep ams
> 3. switch AMS to embedded mode
> 4. restart AMS
> 5. ps -elf | grep ams and will see AMS HBase regionserver process from previous AMS distributed configs is still alive
>
> The fix is when AMS is in embedded mode, make sure no residual region server process is running at collector stop.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py f423165
> ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py 7df74bf
>
> Diff: https://reviews.apache.org/r/56603/diff/
>
>
> Testing
> -------
>
> The fix has been tested via HDP UI.
> The unit testcase test_metrics_collector.py has been updated to reflect the change.
>
>
> Thanks,
>
> Qin Liu
>
>
Re: Review Request 56603: AMBARI-19953: AMS HBase RegionServer
process is still alive after switching AMS to embedded mode
Posted by Qin Liu <qi...@gmail.com>.
> On Feb. 13, 2017, 7:39 p.m., Aravindan Vijayan wrote:
> > Ship It!
Thank you very much Aravindan!
- Qin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56603/#review165382
-----------------------------------------------------------
On Feb. 13, 2017, 7:22 p.m., Qin Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56603/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 7:22 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle.
>
>
> Bugs: AMBARI-19953
> https://issues.apache.org/jira/browse/AMBARI-19953
>
>
> Repository: ambari
>
>
> Description
> -------
>
> After switching AMS to embedded mode, AMS HBase region server process from previous AMS configs is still alive.
>
> Steps to reproduce:
> 1. install a cluster with AMS distributed mode
> 2. ps -elf | grep ams
> 3. switch AMS to embedded mode
> 4. restart AMS
> 5. ps -elf | grep ams and will see AMS HBase regionserver process from previous AMS distributed configs is still alive
>
> The fix is when AMS is in embedded mode, make sure no residual region server process is running at collector stop.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py f423165
> ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py 7df74bf
>
> Diff: https://reviews.apache.org/r/56603/diff/
>
>
> Testing
> -------
>
> The fix has been tested via HDP UI.
> The unit testcase test_metrics_collector.py has been updated to reflect the change.
>
>
> Thanks,
>
> Qin Liu
>
>
Re: Review Request 56603: AMBARI-19953: AMS HBase RegionServer
process is still alive after switching AMS to embedded mode
Posted by Qin Liu <qi...@gmail.com>.
> On Feb. 13, 2017, 7:39 p.m., Aravindan Vijayan wrote:
> > Ship It!
>
> Qin Liu wrote:
> Thank you very much Aravindan!
Hi Aravindan, I would really appreciate if you can commit the changes to trunk.
- Qin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56603/#review165382
-----------------------------------------------------------
On Feb. 13, 2017, 7:22 p.m., Qin Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56603/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 7:22 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle.
>
>
> Bugs: AMBARI-19953
> https://issues.apache.org/jira/browse/AMBARI-19953
>
>
> Repository: ambari
>
>
> Description
> -------
>
> After switching AMS to embedded mode, AMS HBase region server process from previous AMS configs is still alive.
>
> Steps to reproduce:
> 1. install a cluster with AMS distributed mode
> 2. ps -elf | grep ams
> 3. switch AMS to embedded mode
> 4. restart AMS
> 5. ps -elf | grep ams and will see AMS HBase regionserver process from previous AMS distributed configs is still alive
>
> The fix is when AMS is in embedded mode, make sure no residual region server process is running at collector stop.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py f423165
> ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py 7df74bf
>
> Diff: https://reviews.apache.org/r/56603/diff/
>
>
> Testing
> -------
>
> The fix has been tested via HDP UI.
> The unit testcase test_metrics_collector.py has been updated to reflect the change.
>
>
> Thanks,
>
> Qin Liu
>
>
Re: Review Request 56603: AMBARI-19953: AMS HBase RegionServer
process is still alive after switching AMS to embedded mode
Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56603/#review165382
-----------------------------------------------------------
Ship it!
Ship It!
- Aravindan Vijayan
On Feb. 13, 2017, 7:22 p.m., Qin Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56603/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2017, 7:22 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sid Wagle.
>
>
> Bugs: AMBARI-19953
> https://issues.apache.org/jira/browse/AMBARI-19953
>
>
> Repository: ambari
>
>
> Description
> -------
>
> After switching AMS to embedded mode, AMS HBase region server process from previous AMS configs is still alive.
>
> Steps to reproduce:
> 1. install a cluster with AMS distributed mode
> 2. ps -elf | grep ams
> 3. switch AMS to embedded mode
> 4. restart AMS
> 5. ps -elf | grep ams and will see AMS HBase regionserver process from previous AMS distributed configs is still alive
>
> The fix is when AMS is in embedded mode, make sure no residual region server process is running at collector stop.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams_service.py f423165
> ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py 7df74bf
>
> Diff: https://reviews.apache.org/r/56603/diff/
>
>
> Testing
> -------
>
> The fix has been tested via HDP UI.
> The unit testcase test_metrics_collector.py has been updated to reflect the change.
>
>
> Thanks,
>
> Qin Liu
>
>