You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "Abhitocode (via GitHub)" <gi...@apache.org> on 2024/07/10 02:24:27 UTC
[PR] [incubator-kie-issues-1259] RestWorkItemHandler logger set to debug [incubator-kie-kogito-runtimes]
Abhitocode opened a new pull request, #3577:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3577
The logging output from RestWorkItemHandler generates too many logs which is not helpful. Changed the log level from info to debug.
Closes: [https://github.com/apache/incubator-kie-kogito-runtimes/pull/3559](url)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1259] RestWorkItemHandler logger set to debug [incubator-kie-kogito-runtimes]
Posted by "Abhitocode (via GitHub)" <gi...@apache.org>.
Abhitocode commented on PR #3577:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3577#issuecomment-2220514171
Issue link updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1259] RestWorkItemHandler logger set to debug [incubator-kie-kogito-runtimes]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on PR #3577:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3577#issuecomment-2220122925
Link [https://github.com/apache/incubator-kie-kogito-runtimes/pull/3559](https://github.com/apache/incubator-kie-kogito-runtimes/pull/url) does not exist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1259] RestWorkItemHandler logger set to debug [incubator-kie-kogito-runtimes]
Posted by "pefernan (via GitHub)" <gi...@apache.org>.
pefernan merged PR #3577:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1259] RestWorkItemHandler logger set to debug [incubator-kie-kogito-runtimes]
Posted by "Abhitocode (via GitHub)" <gi...@apache.org>.
Abhitocode commented on code in PR #3577:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3577#discussion_r1676030480
##########
kogito-workitems/kogito-rest-workitem/src/main/java/org/kogito/workitem/rest/RestWorkItemHandler.java:
##########
@@ -152,27 +152,27 @@ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager manag
path += "?" + query;
}
} catch (MalformedURLException ex) {
- logger.info("Parameter endpoint {} is not valid uri {}", endPoint, ex.getMessage());
+ logger.debug("Parameter endpoint {} is not valid uri {}", endPoint, ex.getMessage());
Review Comment:
I understand, will update based on further inputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1259] RestWorkItemHandler logger set to debug [incubator-kie-kogito-runtimes]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #3577:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3577#discussion_r1675551614
##########
kogito-workitems/kogito-rest-workitem/src/main/java/org/kogito/workitem/rest/RestWorkItemHandler.java:
##########
@@ -229,7 +229,7 @@ private Class<?> getType(KogitoWorkItem workItem, String varName) {
return variable.getType().getObjectClass();
}
}
- logger.info("Cannot find definition for variable {}", varName);
+ logger.debug("Cannot find definition for variable {}", varName);
Review Comment:
After checking the issue, this particular one I think should remain info, because thats a non frequent situation the user should be aware of, event when not debugging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1259] RestWorkItemHandler logger set to debug [incubator-kie-kogito-runtimes]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #3577:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3577#discussion_r1672017698
##########
kogito-workitems/kogito-rest-workitem/src/main/java/org/kogito/workitem/rest/RestWorkItemHandler.java:
##########
@@ -152,27 +152,27 @@ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager manag
path += "?" + query;
}
} catch (MalformedURLException ex) {
- logger.info("Parameter endpoint {} is not valid uri {}", endPoint, ex.getMessage());
+ logger.debug("Parameter endpoint {} is not valid uri {}", endPoint, ex.getMessage());
Review Comment:
This one should not be a frequent situation, so having it as info seems proper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1259] RestWorkItemHandler logger set to debug [incubator-kie-kogito-runtimes]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #3577:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3577#discussion_r1672019736
##########
kogito-workitems/kogito-rest-workitem/src/main/java/org/kogito/workitem/rest/RestWorkItemHandler.java:
##########
@@ -229,7 +229,7 @@ private Class<?> getType(KogitoWorkItem workItem, String varName) {
return variable.getType().getObjectClass();
}
}
- logger.info("Cannot find definition for variable {}", varName);
+ logger.debug("Cannot find definition for variable {}", varName);
Review Comment:
This one also seems a valid info situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1259] RestWorkItemHandler logger set to debug [incubator-kie-kogito-runtimes]
Posted by "Abhitocode (via GitHub)" <gi...@apache.org>.
Abhitocode commented on code in PR #3577:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3577#discussion_r1672265477
##########
kogito-workitems/kogito-rest-workitem/src/main/java/org/kogito/workitem/rest/RestWorkItemHandler.java:
##########
@@ -152,27 +152,27 @@ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager manag
path += "?" + query;
}
} catch (MalformedURLException ex) {
- logger.info("Parameter endpoint {} is not valid uri {}", endPoint, ex.getMessage());
+ logger.debug("Parameter endpoint {} is not valid uri {}", endPoint, ex.getMessage());
Review Comment:
Okay will compare and update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1259] RestWorkItemHandler logger set to debug [incubator-kie-kogito-runtimes]
Posted by "fjtirado (via GitHub)" <gi...@apache.org>.
fjtirado commented on code in PR #3577:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3577#discussion_r1675550751
##########
kogito-workitems/kogito-rest-workitem/src/main/java/org/kogito/workitem/rest/RestWorkItemHandler.java:
##########
@@ -152,27 +152,27 @@ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager manag
path += "?" + query;
}
} catch (MalformedURLException ex) {
- logger.info("Parameter endpoint {} is not valid uri {}", endPoint, ex.getMessage());
+ logger.debug("Parameter endpoint {} is not valid uri {}", endPoint, ex.getMessage());
Review Comment:
After checking the issue description, this one is indeed debug (I think is highly debatable if all logs should be info or debug for RestWorkItemHandler, but accepting they should be debug, this particular one lies in the same category that the host, port and path)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org