[GitHub] [spark] srowen commented on a change in pull request #24431: [SPARK-27536][CORE][ML][SQL][STREAMING] Remove most use of scala.language.existentials

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24431: [SPARK-27536][CORE][ML][SQL][STREAMING] Remove most use of scala.language.existentials
URL: https://github.com/apache/spark/pull/24431#discussion_r278564827
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/image/HadoopUtils.scala
 ##########
 @@ -103,16 +102,16 @@ private object SamplePathFilter {
       // scalastyle:off hadoopconfiguration
       val hadoopConf = spark.sparkContext.hadoopConfiguration
       // scalastyle:on hadoopconfiguration
-      val old = Option(hadoopConf.getClass(flagName, null))
+      val old = hadoopConf.getClass(flagName, null)
 
 Review comment:
   Same sort of issue: assigning `Option[Class[_]]` caused the warning. Here it seemed as fine to stick with the underlying null vs not-null.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org