[GitHub] [superset] codyml commented on a diff in pull request #21315: fix(explore): Prevent shared controls from checking feature flags outside React render

[GitBox <gi...@apache.org>]

codyml commented on code in PR #21315:
URL: https://github.com/apache/superset/pull/21315#discussion_r1012398376


##########
superset-frontend/packages/superset-ui-chart-controls/src/types.ts:
##########
@@ -237,7 +237,7 @@ export interface BaseControlConfig<
   ) => boolean;
   mapStateToProps?: (
     state: ControlPanelState,
-    controlState: ControlState,
+    controlState?: ControlState,

Review Comment:
   Hmm, I think that was a quick fix to stop the histogram viz plugin from complaining after I updated it to use shared controls.  I opened [a PR](https://github.com/apache/superset/pull/22014) that reverts that change and instead updates the plugin – does that look like a better solution?  Would be great to spin up an ephemeral env to check if there are any side-effects for Histogram charts.



##########
superset-frontend/packages/superset-ui-chart-controls/src/types.ts:
##########
@@ -237,7 +237,7 @@ export interface BaseControlConfig<
   ) => boolean;
   mapStateToProps?: (
     state: ControlPanelState,
-    controlState: ControlState,
+    controlState?: ControlState,

Review Comment:
   (Assuming it passes CI)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org