You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Guillaume Durand (JIRA)" <ji...@apache.org> on 2009/04/01 13:11:13 UTC

[jira] Created: (FELIX-1021) Classifier always used even if not explicitly set in the configuration

Classifier always used even if not explicitly set in the configuration
----------------------------------------------------------------------

                 Key: FELIX-1021
                 URL: https://issues.apache.org/jira/browse/FELIX-1021
             Project: Felix
          Issue Type: Bug
          Components: Maven Bundle Plugin
    Affects Versions: maven-bundle-plugin-2.0.0
         Environment: Maven 2.1.0
            Reporter: Guillaume Durand


If I build a bundle specifying a classifier in the command line, this classifier is used even if I did not explicitly used the classifier property in the bundle configuration. This is not consistent with the jar plugin for instance, which requires the classifier property to be set in the plugin configuration in order to really use the classifier.

This behaviour is very problematic for by builds because I use parent projets to build several child projects, some of which needing a classifier (typically bundles containing native code). With the current behaviour, if I build the parent project with classifier linux-x86, all the bundles (even pure java bundles) will be classified. This is not wanted.

With previous versions of maven I could set a classifier property in the pom file to null when I did not want the classifier for a particular bundle, but now this workaround no longer works.

To fix the problem replace in BundlePlugin.java:

* @parameter expression="${classifier}"
*/
protected String classifier;

with 

* @parameter
*/
protected String classifier;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-1021) Classifier always used even if not explicitly set in the configuration

Posted by "Guillaume Durand (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694571#action_12694571 ] 

Guillaume Durand commented on FELIX-1021:
-----------------------------------------

Actually this fix works only on my machine...
On the integration server and colleagues machines I still have the classifier appended.

> Classifier always used even if not explicitly set in the configuration
> ----------------------------------------------------------------------
>
>                 Key: FELIX-1021
>                 URL: https://issues.apache.org/jira/browse/FELIX-1021
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-2.0.0
>         Environment: Maven 2.1.0
>            Reporter: Guillaume Durand
>
> If I build a bundle specifying a classifier in the command line, this classifier is used even if I did not explicitly used the classifier property in the bundle configuration. This is not consistent with the jar plugin for instance, which requires the classifier property to be set in the plugin configuration in order to really use the classifier.
> This behaviour is very problematic for by builds because I use parent projets to build several child projects, some of which needing a classifier (typically bundles containing native code). With the current behaviour, if I build the parent project with classifier linux-x86, all the bundles (even pure java bundles) will be classified. This is not wanted.
> With previous versions of maven I could set a classifier property in the pom file to null when I did not want the classifier for a particular bundle, but now this workaround no longer works.
> To fix the problem replace in BundlePlugin.java:
> * @parameter expression="${classifier}"
> */
> protected String classifier;
> with 
> * @parameter
> */
> protected String classifier;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-1021) Classifier always used even if not explicitly set in the configuration

Posted by "Guillaume Durand (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Guillaume Durand updated FELIX-1021:
------------------------------------

    Comment: was deleted

(was: Actually this fix works only on my machine...
On the integration server and colleagues machines I still have the classifier appended.)

> Classifier always used even if not explicitly set in the configuration
> ----------------------------------------------------------------------
>
>                 Key: FELIX-1021
>                 URL: https://issues.apache.org/jira/browse/FELIX-1021
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-2.0.0
>         Environment: Maven 2.1.0
>            Reporter: Guillaume Durand
>
> If I build a bundle specifying a classifier in the command line, this classifier is used even if I did not explicitly used the classifier property in the bundle configuration. This is not consistent with the jar plugin for instance, which requires the classifier property to be set in the plugin configuration in order to really use the classifier.
> This behaviour is very problematic for by builds because I use parent projets to build several child projects, some of which needing a classifier (typically bundles containing native code). With the current behaviour, if I build the parent project with classifier linux-x86, all the bundles (even pure java bundles) will be classified. This is not wanted.
> With previous versions of maven I could set a classifier property in the pom file to null when I did not want the classifier for a particular bundle, but now this workaround no longer works.
> To fix the problem replace in BundlePlugin.java:
> * @parameter expression="${classifier}"
> */
> protected String classifier;
> with 
> * @parameter
> */
> protected String classifier;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-1021) Classifier always used even if not explicitly set in the configuration

Posted by "Stuart McCulloch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stuart McCulloch updated FELIX-1021:
------------------------------------

    Fix Version/s: maven-bundle-plugin-2.0.1

Schedule for the next maintenance release (2.0.1) but also need to confirm this won't break any existing builds

> Classifier always used even if not explicitly set in the configuration
> ----------------------------------------------------------------------
>
>                 Key: FELIX-1021
>                 URL: https://issues.apache.org/jira/browse/FELIX-1021
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-2.0.0
>         Environment: Maven 2.1.0
>            Reporter: Guillaume Durand
>             Fix For: maven-bundle-plugin-2.0.1
>
>
> If I build a bundle specifying a classifier in the command line, this classifier is used even if I did not explicitly used the classifier property in the bundle configuration. This is not consistent with the jar plugin for instance, which requires the classifier property to be set in the plugin configuration in order to really use the classifier.
> This behaviour is very problematic for by builds because I use parent projets to build several child projects, some of which needing a classifier (typically bundles containing native code). With the current behaviour, if I build the parent project with classifier linux-x86, all the bundles (even pure java bundles) will be classified. This is not wanted.
> With previous versions of maven I could set a classifier property in the pom file to null when I did not want the classifier for a particular bundle, but now this workaround no longer works.
> To fix the problem replace in BundlePlugin.java:
> * @parameter expression="${classifier}"
> */
> protected String classifier;
> with 
> * @parameter
> */
> protected String classifier;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (FELIX-1021) Classifier always used even if not explicitly set in the configuration

Posted by "Stuart McCulloch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stuart McCulloch reassigned FELIX-1021:
---------------------------------------

    Assignee: Stuart McCulloch

> Classifier always used even if not explicitly set in the configuration
> ----------------------------------------------------------------------
>
>                 Key: FELIX-1021
>                 URL: https://issues.apache.org/jira/browse/FELIX-1021
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-2.0.0
>         Environment: Maven 2.1.0
>            Reporter: Guillaume Durand
>            Assignee: Stuart McCulloch
>             Fix For: maven-bundle-plugin-2.0.1
>
>
> If I build a bundle specifying a classifier in the command line, this classifier is used even if I did not explicitly used the classifier property in the bundle configuration. This is not consistent with the jar plugin for instance, which requires the classifier property to be set in the plugin configuration in order to really use the classifier.
> This behaviour is very problematic for by builds because I use parent projets to build several child projects, some of which needing a classifier (typically bundles containing native code). With the current behaviour, if I build the parent project with classifier linux-x86, all the bundles (even pure java bundles) will be classified. This is not wanted.
> With previous versions of maven I could set a classifier property in the pom file to null when I did not want the classifier for a particular bundle, but now this workaround no longer works.
> To fix the problem replace in BundlePlugin.java:
> * @parameter expression="${classifier}"
> */
> protected String classifier;
> with 
> * @parameter
> */
> protected String classifier;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (FELIX-1021) Classifier always used even if not explicitly set in the configuration

Posted by "Stuart McCulloch (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stuart McCulloch resolved FELIX-1021.
-------------------------------------

    Resolution: Fixed

Fixed in r810600.

> Classifier always used even if not explicitly set in the configuration
> ----------------------------------------------------------------------
>
>                 Key: FELIX-1021
>                 URL: https://issues.apache.org/jira/browse/FELIX-1021
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-2.0.0
>         Environment: Maven 2.1.0
>            Reporter: Guillaume Durand
>            Assignee: Stuart McCulloch
>             Fix For: maven-bundle-plugin-2.0.1
>
>
> If I build a bundle specifying a classifier in the command line, this classifier is used even if I did not explicitly used the classifier property in the bundle configuration. This is not consistent with the jar plugin for instance, which requires the classifier property to be set in the plugin configuration in order to really use the classifier.
> This behaviour is very problematic for by builds because I use parent projets to build several child projects, some of which needing a classifier (typically bundles containing native code). With the current behaviour, if I build the parent project with classifier linux-x86, all the bundles (even pure java bundles) will be classified. This is not wanted.
> With previous versions of maven I could set a classifier property in the pom file to null when I did not want the classifier for a particular bundle, but now this workaround no longer works.
> To fix the problem replace in BundlePlugin.java:
> * @parameter expression="${classifier}"
> */
> protected String classifier;
> with 
> * @parameter
> */
> protected String classifier;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.