You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "abhishekbhakat (via GitHub)" <gi...@apache.org> on 2024/07/23 11:06:14 UTC
[PR] Deprecation warnings for using task log prefix template [airflow]
abhishekbhakat opened a new pull request, #40952:
URL: https://github.com/apache/airflow/pull/40952
closes: #39019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecation warnings for using task log prefix template [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40952:
URL: https://github.com/apache/airflow/pull/40952#issuecomment-2336490329
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecation warnings for using task log prefix template [airflow]
Posted by "abhishekbhakat (via GitHub)" <gi...@apache.org>.
abhishekbhakat commented on PR #40952:
URL: https://github.com/apache/airflow/pull/40952#issuecomment-2244952461
I don't actually like adding anything to `TaskHandlerWithCustomFormatter` class as this code is totally unreachable.
Just adding the warning in configuration should be fine.
Screenshot of the warning in cli:
<img width="1441" alt="Screenshot 2024-07-23 at 11 10 47" src="https://github.com/user-attachments/assets/c22db088-39c7-4fa1-a5b4-506bdfe90855">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecation warnings for using task log prefix template [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #40952: Deprecation warnings for using task log prefix template
URL: https://github.com/apache/airflow/pull/40952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Deprecation warnings for using task log prefix template [airflow]
Posted by "abhishekbhakat (via GitHub)" <gi...@apache.org>.
abhishekbhakat commented on PR #40952:
URL: https://github.com/apache/airflow/pull/40952#issuecomment-2245595629
Also, how should I handle tests?
According to docs:
https://github.com/apache/airflow/blob/efca50afe0d966402a149d3c4cbce1dbde0750ce/contributing-docs/testing/unit_tests.rst?plain=1#L39-L46
I can then just ignore the Warning in the module. Cause anyway the code is unreachable. Or drop the tests (_which doesn't make much sense to do for now_)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org