[CODE] need review for issue 119308

[eric b <er...@free.fr>]

Hi,

Can someone review the patch I attached to the issue ?
See:  https://issues.apache.org/ooo/show_bug.cgi?id=119308


Thanks in advance,
Eric

-- 
qɔᴉɹə
Projet OOo4Kids : http://wiki.ooo4kids.org/index.php/Main_Page
L'association EducOOo : http://www.educoo.org
Blog : http://eric.bachard.org/news

Re: [CODE] need review for issue 119308

[Andre Fischer <af...@a-w-f.de>]

On 08.05.2012 17:12, Yong Lin Ma wrote:
> For boost/prj/d.lst, how about replacing
>
> mkdir: %_DEST%\inc%_EXT%\boost\functional
> mkdir: %_DEST%\inc%_EXT%\boost\functional\detail
> mkdir: %_DEST%\inc%_EXT%\boost\functional
> mkdir: %_DEST%\inc%_EXT%\boost\functional\hash
> mkdir: %_DEST%\inc%_EXT%\boost\functional\hash\detail
> mkdir: %_DEST%\inc%_EXT%\boost\integer
> ..\%__SRC%\misc\build\boost_1_39_0\boost\integer\*
> %_DEST%\inc%_EXT%\boost\integer
> ..\%__SRC%\misc\build\boost_1_39_0\boost\functional\*
> %_DEST%\inc%_EXT%\boost\functional
> ..\%__SRC%\misc\build\boost_1_39_0\boost\functional\hash\*
> %_DEST%\inc%_EXT%\boost\functional\hash
> ..\%__SRC%\misc\build\boost_1_39_0\boost\functional\hash\detail\*
> %_DEST%\inc%_EXT%\boost\functional\hash\detail
>
>   with:
>
> dos: sh -c "cp -r ..\%__SRC%\misc\build\boost_1_39_0\boost\integer
> %_DEST%\inc%_EXT%\boost"
> dos: sh -c "cp -r ..\%__SRC%\misc\build\boost_1_39_0\boost\functional
> %_DEST%\inc%_EXT%\boost"

While this is technically possible, I strongly advise against it:


- The upper version copies only a part of the .../boost/integer and 
.../boost/functional directory trees.  The lower version copies 
everything in them.

- The "dos:" prefix in deliver scripts seems to be a seldomly used hack 
for some now unknown problem.

- If you look at main/solenv/bin/deliver.pl then you will see, that code 
for handling the normal copy lines is much more sophisticated than the 
code for "dos:" (compare do_copy to do_dos): eg do_copy only copies 
files that are newer than at the destination.



Best regards,
Andre

>
>
> On Mon, May 7, 2012 at 3:30 PM, Andre Fischer<af...@a-w-f.de>  wrote:
>> On 05.05.2012 08:51, eric b wrote:
>>>
>>> Hi,
>>>
>>> Can someone review the patch I attached to the issue ?
>>> See: https://issues.apache.org/ooo/show_bug.cgi?id=119308
>>
>>
>> I did not compile it, but the patch looks good.
>>
>> Thank you,
>>
>> Andre
>>
>>>
>>>
>>> Thanks in advance,
>>> Eric
>>>
>>

Re: [CODE] need review for issue 119308

[Yong Lin Ma <ma...@gmail.com>]

For boost/prj/d.lst, how about replacing

mkdir: %_DEST%\inc%_EXT%\boost\functional
mkdir: %_DEST%\inc%_EXT%\boost\functional\detail
mkdir: %_DEST%\inc%_EXT%\boost\functional
mkdir: %_DEST%\inc%_EXT%\boost\functional\hash
mkdir: %_DEST%\inc%_EXT%\boost\functional\hash\detail
mkdir: %_DEST%\inc%_EXT%\boost\integer
..\%__SRC%\misc\build\boost_1_39_0\boost\integer\*
%_DEST%\inc%_EXT%\boost\integer
..\%__SRC%\misc\build\boost_1_39_0\boost\functional\*
%_DEST%\inc%_EXT%\boost\functional
..\%__SRC%\misc\build\boost_1_39_0\boost\functional\hash\*
%_DEST%\inc%_EXT%\boost\functional\hash
..\%__SRC%\misc\build\boost_1_39_0\boost\functional\hash\detail\*
%_DEST%\inc%_EXT%\boost\functional\hash\detail

 with:

dos: sh -c "cp -r ..\%__SRC%\misc\build\boost_1_39_0\boost\integer
%_DEST%\inc%_EXT%\boost"
dos: sh -c "cp -r ..\%__SRC%\misc\build\boost_1_39_0\boost\functional
%_DEST%\inc%_EXT%\boost"


On Mon, May 7, 2012 at 3:30 PM, Andre Fischer <af...@a-w-f.de> wrote:
> On 05.05.2012 08:51, eric b wrote:
>>
>> Hi,
>>
>> Can someone review the patch I attached to the issue ?
>> See: https://issues.apache.org/ooo/show_bug.cgi?id=119308
>
>
> I did not compile it, but the patch looks good.
>
> Thank you,
>
> Andre
>
>>
>>
>> Thanks in advance,
>> Eric
>>
>

Re: [CODE] need review for issue 119308

[Andre Fischer <af...@a-w-f.de>]

On 05.05.2012 08:51, eric b wrote:
> Hi,
>
> Can someone review the patch I attached to the issue ?
> See: https://issues.apache.org/ooo/show_bug.cgi?id=119308

I did not compile it, but the patch looks good.

Thank you,

Andre

>
>
> Thanks in advance,
> Eric
>