You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/01/28 05:16:27 UTC
[GitHub] [phoenix] stoty opened a new pull request #1116: PHOENIX-5543: Implement SHOW TABLES/SCHEMAS sql commands
stoty opened a new pull request #1116:
URL: https://github.com/apache/phoenix/pull/1116
This patch adds new SQL grammar like following
- SHOW SCHEMAS [like '<pattern>']
- SHOW TABLES [IN <schema>] [like '<pattern']
Example invocations:
- show schemas
- show scemas like 'SYS%'
- show tables
- show tables in SYSTEM
- show tables in SYSTEM like 'CAT%'
The current way of fetching this information is by using
!tables and !schemas via sqlline JDBC support but that is
not flexible enough for the end users to add more fitlers.
This approach is more inline with what other databases do.
Added test coverage in parser tests and core e2e tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1116: PHOENIX-5543: Implement SHOW TABLES/SCHEMAS sql commands
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1116:
URL: https://github.com/apache/phoenix/pull/1116#issuecomment-770674569
Oh yes, this is nice feature. Agree, we should add it in 4.16.
FYI @yanxinyi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani edited a comment on pull request #1116: PHOENIX-5543: Implement SHOW TABLES/SCHEMAS sql commands
Posted by GitBox <gi...@apache.org>.
virajjasani edited a comment on pull request #1116:
URL: https://github.com/apache/phoenix/pull/1116#issuecomment-770674569
Oh yes, this is nice feature. Agree, we should add it in 4.16.
In fact, i was just thinking about this one last week. Somehow didn't realize that this is not on 4.16 branch already.
FYI @yanxinyi
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on pull request #1116: PHOENIX-5543: Implement SHOW TABLES/SCHEMAS sql commands
Posted by GitBox <gi...@apache.org>.
virajjasani commented on pull request #1116:
URL: https://github.com/apache/phoenix/pull/1116#issuecomment-770682049
I remember running tests `testShowTables()` and other relevant test with this patch on master branch and since they passed in QA, i think there should not be any issue with this straight-forward backport.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1116: PHOENIX-5543: Implement SHOW TABLES/SCHEMAS sql commands
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1116:
URL: https://github.com/apache/phoenix/pull/1116#issuecomment-770662683
@yanxinyi @virajjasani
This is a rather nice feature that was never merged to 4x.
I think it's worthwhile to get this into 4.16
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #1116: PHOENIX-5543: Implement SHOW TABLES/SCHEMAS sql commands
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #1116:
URL: https://github.com/apache/phoenix/pull/1116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1116: PHOENIX-5543: Implement SHOW TABLES/SCHEMAS sql commands
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1116:
URL: https://github.com/apache/phoenix/pull/1116#issuecomment-770683611
Thanks, I'll re-run UpsertSelectIT locally, and if it doesn't fail, I'm going to merge this in a few hours.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1116: PHOENIX-5543: Implement SHOW TABLES/SCHEMAS sql commands
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1116:
URL: https://github.com/apache/phoenix/pull/1116#issuecomment-770675957
If I get a +1 it, I will commit this to 4.x
It was a rather straigtforward backport I don't expect problems with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1116: PHOENIX-5543: Implement SHOW TABLES/SCHEMAS sql commands
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1116:
URL: https://github.com/apache/phoenix/pull/1116#issuecomment-768927752
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 57s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 4m 59s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 9m 50s | 4.x passed |
| +1 :green_heart: | compile | 1m 35s | 4.x passed |
| +1 :green_heart: | checkstyle | 2m 9s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 3s | 4.x passed |
| +0 :ok: | spotbugs | 2m 55s | phoenix-core in 4.x has 945 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 51s | phoenix-pherf in 4.x has 42 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 50s | the patch passed |
| +1 :green_heart: | compile | 1m 38s | the patch passed |
| +1 :green_heart: | javac | 1m 38s | the patch passed |
| -1 :x: | checkstyle | 1m 53s | phoenix-core: The patch generated 278 new + 3380 unchanged - 143 fixed = 3658 total (was 3523) |
| -1 :x: | checkstyle | 0m 15s | phoenix-pherf: The patch generated 1 new + 182 unchanged - 6 fixed = 183 total (was 188) |
| -1 :x: | whitespace | 0m 0s | The patch 1 line(s) with tabs. |
| +1 :green_heart: | javadoc | 1m 0s | the patch passed |
| -1 :x: | spotbugs | 3m 14s | phoenix-core generated 5 new + 940 unchanged - 5 fixed = 945 total (was 945) |
||| _ Other Tests _ |
| -1 :x: | unit | 204m 24s | phoenix-core in the patch failed. |
| +1 :green_heart: | unit | 10m 13s | phoenix-pherf in the patch passed. |
| +1 :green_heart: | asflicense | 1m 33s | The patch does not generate ASF License warnings. |
| | | 262m 47s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.util.QueryUtil.getCatalogsStmt(PhoenixConnection) may fail to clean up java.sql.Statement on checked exception Obligation to clean up resource created at QueryUtil.java:up java.sql.Statement on checked exception Obligation to clean up resource created at QueryUtil.java:[line 528] is not discharged |
| | org.apache.phoenix.util.QueryUtil.getIndexInfoStmt(PhoenixConnection, String, String, String, boolean, boolean) may fail to clean up java.sql.Statement on checked exception Obligation to clean up resource created at QueryUtil.java:boolean) may fail to clean up java.sql.Statement on checked exception Obligation to clean up resource created at QueryUtil.java:[line 633] is not discharged |
| | org.apache.phoenix.util.QueryUtil.getSchemasStmt(PhoenixConnection, String, String) may fail to clean up java.sql.Statement on checked exception Obligation to clean up resource created at QueryUtil.java:to clean up java.sql.Statement on checked exception Obligation to clean up resource created at QueryUtil.java:[line 558] is not discharged |
| | org.apache.phoenix.util.QueryUtil.getSuperTablesStmt(PhoenixConnection, String, String, String) may fail to clean up java.sql.Statement on checked exception Obligation to clean up resource created at QueryUtil.java:fail to clean up java.sql.Statement on checked exception Obligation to clean up resource created at QueryUtil.java:[line 588] is not discharged |
| | org.apache.phoenix.util.QueryUtil.getTablesStmt(PhoenixConnection, String, String, String, String[]) may fail to clean up java.sql.Statement on checked exception Obligation to clean up resource created at QueryUtil.java:may fail to clean up java.sql.Statement on checked exception Obligation to clean up resource created at QueryUtil.java:[line 763] is not discharged |
| Failed junit tests | phoenix.end2end.DropTableWithViewsIT |
| | phoenix.end2end.UpsertSelectIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1116/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1116 |
| JIRA Issue | PHOENIX-5543 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 98f076aa7d87 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 44d4402 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1116/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1116/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-pherf.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1116/1/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1116/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1116/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1116/1/testReport/ |
| Max. process+thread count | 4838 (vs. ulimit of 30000) |
| modules | C: phoenix-core phoenix-pherf U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1116/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org