Re: [PR] GH-39803: [C++][Acero] Fix AsOfJoin with differently ordered schemas than the output [arrow]

["pitrou (via GitHub)" <gi...@apache.org>]

pitrou commented on code in PR #39804:
URL: https://github.com/apache/arrow/pull/39804#discussion_r1486469974


##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -16,6 +16,7 @@
 // under the License.
 
 #include <gmock/gmock-matchers.h>
+#include <iostream>  // nocommit

Review Comment:
   Is this required? Also, what is "nocommit" for?



##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1582,6 +1583,66 @@ TEST(AsofJoinTest, BatchSequencing) {
   return TestSequencing(MakeIntegerBatches, /*num_batches=*/32, /*batch_size=*/1);
 }
 
+template <typename BatchesMaker>
+void TestSchemaResolution(BatchesMaker maker, int num_batches, int batch_size) {
+  auto l_schema =

Review Comment:
   Can you add a comment explaining this test, together with a reference to the GH issue?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org