[GitHub] [poi] pjfanning commented on a diff in pull request #496: Bug 66855 Formula parser incorrectly handles sheet name containing multiple single quotes in a row

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on code in PR #496:
URL: https://github.com/apache/poi/pull/496#discussion_r1285107778


##########
poi/src/test/java/org/apache/poi/hssf/model/TestFormulaParser.java:
##########
@@ -1357,8 +1357,8 @@ void testUnionOfFullCollFullRowRef() throws IOException {
                 UnionPtg.class
         );
 
-        wb.createSheet("Sh't1");
-        ptgs = parse("'Sh''t1'!$A:$A,'Sh''t1'!$1:$4", wb);

Review Comment:
   could you add a new test and leave this one as is? It must be useful to keep the test for `"Sh't1"`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org