You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/22 23:09:01 UTC
[GitHub] [airflow] potiuk opened a new pull request #18450: Avoid importing DAGs during clean DB installation
potiuk opened a new pull request #18450:
URL: https://github.com/apache/airflow/pull/18450
One of our migration (adding max_tries) creates the DagBag and
effectively parses all the DAGS while performing the migraiions.
While this is needed in case you migrate from an older version of
the DB where you have some TaskInstances requiring migration, for
an empty database, there are no TaskInstance entities in the DB
and parsing of all the DAGs is not needed.
Actually it can even be harmful. If you attempt to run Airflow
Migration on an empty dataase and your DAGs will be erroneous,
your migration will break in the middle and you have no
clue what caused it = see #18408 for an example of such failure.
This PR skips DagBag import when there are no TaskInstance in
the database to migrate.
Fixes: #18449
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18450: Avoid importing DAGs during clean DB installation
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18450:
URL: https://github.com/apache/airflow/pull/18450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18450: Avoid importing DAGs during clean DB installation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18450:
URL: https://github.com/apache/airflow/pull/18450#issuecomment-925397785
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org