You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2021/10/11 16:35:13 UTC

[kudu-CR] [master] Expose error when set an unsupported table extra config 

Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17914


Change subject: [master] Expose error when set an unsupported table extra config
......................................................................

[master] Expose error when set an unsupported table extra config

Now table extra configs are set by strings, there is not check on
both client and server sides, a typo is easy happened without any
warnings.
This patch adds a check, an error be returned if setting an
unsupported extra config to a table.

Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9
---
M src/kudu/client/client-test.cc
M src/kudu/common/wire_protocol.cc
2 files changed, 35 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/17914/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9
Gerrit-Change-Number: 17914
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [master] Validate extra config properties for a table

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17914 )

Change subject: [master] Validate extra config properties for a table
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9
Gerrit-Change-Number: 17914
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 18 Oct 2021 18:24:16 +0000
Gerrit-HasComments: No

[kudu-CR] [master] Validate extra config properties for a table

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17914 )

Change subject: [master] Validate extra config properties for a table
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/17914/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17914/2//COMMIT_MSG@7
PS2, Line 7: Validate extra config properties for a table
> How about:
Done


http://gerrit.cloudera.org:8080/#/c/17914/2//COMMIT_MSG@9
PS2, Line 9: Prior to this patch, no validation was performed on the strings
           : representing the keys of extra configuration properties for a
           : table.
           : This patch adds the missing validation logic, so now an error
           : is returned on attempt to set unsupp
> How about:
Done


http://gerrit.cloudera.org:8080/#/c/17914/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

http://gerrit.cloudera.org:8080/#/c/17914/2/src/kudu/client/client-test.cc@4787
PS2, Line 4787: ASSERT_TRUE(s.IsInvalidArgument()) 
> nit: when an assertion like this triggers, it's easier to debug if the info
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/17914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9
Gerrit-Change-Number: 17914
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 18 Oct 2021 05:50:03 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master] Validate extra config properties for a table

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17914 )

Change subject: [master] Validate extra config properties for a table
......................................................................

[master] Validate extra config properties for a table

Prior to this patch, no validation was performed on the strings
representing the keys of extra configuration properties for a
table.
This patch adds the missing validation logic, so now an error
is returned on attempt to set unsupported extra configuration
properties for a table.

Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9
Reviewed-on: http://gerrit.cloudera.org:8080/17914
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/client/client-test.cc
M src/kudu/common/wire_protocol.cc
2 files changed, 34 insertions(+), 4 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Bankim Bhavsar: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/17914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9
Gerrit-Change-Number: 17914
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [master] Expose error when set an unsupported table extra config

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17914 )

Change subject: [master] Expose error when set an unsupported table extra config
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17914/1/src/kudu/common/wire_protocol.cc
File src/kudu/common/wire_protocol.cc:

http://gerrit.cloudera.org:8080/#/c/17914/1/src/kudu/common/wire_protocol.cc@673
PS1, Line 673: set
Nit: could be unordered_set


http://gerrit.cloudera.org:8080/#/c/17914/1/src/kudu/common/wire_protocol.cc@697
PS1, Line 697: __builtin_unreachable();
Is this still needed with LOG(FATAL)?



-- 
To view, visit http://gerrit.cloudera.org:8080/17914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9
Gerrit-Change-Number: 17914
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 11 Oct 2021 19:09:44 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master] Expose error when set an unsupported table extra config

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17914

to look at the new patch set (#2).

Change subject: [master] Expose error when set an unsupported table extra config
......................................................................

[master] Expose error when set an unsupported table extra config

Now table extra configs are set by strings, there is not check on
both client and server sides, a typo is easy happened without any
warnings.
This patch adds a check, an error be returned if setting an
unsupported extra config to a table.

Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9
---
M src/kudu/client/client-test.cc
M src/kudu/common/wire_protocol.cc
2 files changed, 34 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/17914/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9
Gerrit-Change-Number: 17914
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [master] Expose error when set an unsupported table extra config

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17914 )

Change subject: [master] Expose error when set an unsupported table extra config
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17914/1/src/kudu/common/wire_protocol.cc
File src/kudu/common/wire_protocol.cc:

http://gerrit.cloudera.org:8080/#/c/17914/1/src/kudu/common/wire_protocol.cc@673
PS1, Line 673: uno
> Nit: could be unordered_set
Done


http://gerrit.cloudera.org:8080/#/c/17914/1/src/kudu/common/wire_protocol.cc@697
PS1, Line 697: LOG(FATAL) << "Unknown e
> Is this still needed with LOG(FATAL)?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/17914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9
Gerrit-Change-Number: 17914
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 12 Oct 2021 02:33:56 +0000
Gerrit-HasComments: Yes

[kudu-CR] [master] Validate extra config properties for a table

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17914

to look at the new patch set (#3).

Change subject: [master] Validate extra config properties for a table
......................................................................

[master] Validate extra config properties for a table

Prior to this patch, no validation was performed on the strings
representing the keys of extra configuration properties for a
table.
This patch adds the missing validation logic, so now an error
is returned on attempt to set unsupported extra configuration
properties for a table.

Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9
---
M src/kudu/client/client-test.cc
M src/kudu/common/wire_protocol.cc
2 files changed, 34 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/17914/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9
Gerrit-Change-Number: 17914
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [master] Validate extra config properties for a table

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17914 )

Change subject: [master] Validate extra config properties for a table
......................................................................


Patch Set 3:

Thank you for the improvement!


-- 
To view, visit http://gerrit.cloudera.org:8080/17914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9
Gerrit-Change-Number: 17914
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 18 Oct 2021 18:24:42 +0000
Gerrit-HasComments: No

[kudu-CR] [master] Validate extra config properties for a table

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17914 )

Change subject: [master] Validate extra config properties for a table
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9
Gerrit-Change-Number: 17914
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 18 Oct 2021 18:11:42 +0000
Gerrit-HasComments: No

[kudu-CR] [master] Expose error when set an unsupported table extra config

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17914 )

Change subject: [master] Expose error when set an unsupported table extra config
......................................................................


Patch Set 2: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/17914/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17914/2//COMMIT_MSG@7
PS2, Line 7: Expose error when set an unsupported table extra config
How about:

validate extra config properties for a table


http://gerrit.cloudera.org:8080/#/c/17914/2//COMMIT_MSG@9
PS2, Line 9: Now table extra configs are set by strings, there is not check on
           : both client and server sides, a typo is easy happened without any
           : warnings.
           : This patch adds a check, an error be returned if setting an
           : unsupported extra config to a table.
How about:

Prior to this patch, no validation was performed on the strings representing the keys of extra configuration properties for a table.  This patch adds the missing validation logic, so now an error is returned on attempt to set unsupported extra configuration properties for a table.


http://gerrit.cloudera.org:8080/#/c/17914/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

http://gerrit.cloudera.org:8080/#/c/17914/2/src/kudu/client/client-test.cc@4787
PS2, Line 4787: ASSERT_TRUE(s.IsInvalidArgument());
nit: when an assertion like this triggers, it's easier to debug if the information on the actual status is output as well

ASSERT_TRUE(s.IsInvalidArgument()) << s.ToString();



-- 
To view, visit http://gerrit.cloudera.org:8080/17914
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff5ccc553fdbe164cf342df6882ea0b78a9e10f9
Gerrit-Change-Number: 17914
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Mon, 18 Oct 2021 04:20:36 +0000
Gerrit-HasComments: Yes