You are viewing a plain text version of this content. The canonical link for it is here.
Posted to batik-dev@xmlgraphics.apache.org by bu...@apache.org on 2009/05/15 22:30:45 UTC

DO NOT REPLY [Bug 47202] New: Unnecessary allocation in RectListManager.mergeRects

https://issues.apache.org/bugzilla/show_bug.cgi?id=47202

           Summary: Unnecessary allocation in RectListManager.mergeRects
           Product: Batik
           Version: 1.8
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: SVGGraphics2D
        AssignedTo: batik-dev@xmlgraphics.apache.org
        ReportedBy: dbrosius@apache.org


simple cleanup of unnecessary Rectangle allocation

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org


DO NOT REPLY [Bug 47202] Unnecessary allocation in RectListManager.mergeRects

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47202





--- Comment #2 from Dave Brosius <db...@apache.org>  2009-05-16 11:21:53 PST ---
Created an attachment (id=23671)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23671)
unnecessary alloc

sorry, apparently the patch was lost on submit for some reason, re-adding.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org


DO NOT REPLY [Bug 47202] [PATCH] Unnecessary allocation in RectListManager.mergeRects

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47202


Helder Magalhães <he...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable
             Status|NEEDINFO                    |NEW
            Summary|Unnecessary allocation in   |[PATCH] Unnecessary
                   |RectListManager.mergeRects  |allocation in
                   |                            |RectListManager.mergeRects




--- Comment #3 from Helder Magalhães <he...@gmail.com>  2009-05-17 00:36:22 PST ---
(In reply to comment #2)
> sorry, apparently the patch was lost on submit for some reason, re-adding.

Great, thanks! ;-)

I reviewed it and it looks good (I'd say it's ready to land). Could a Batik
committer take a look at this?

In the meantime, few bug properties were updated: seems like Dave forgot (?) to
change the bug back to "new". ;-)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org


DO NOT REPLY [Bug 47202] Unnecessary allocation in RectListManager.mergeRects

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47202


Helder Magalhães <he...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
                 CC|                            |helder.magalhaes@gmail.com




--- Comment #1 from Helder Magalhães <he...@gmail.com>  2009-05-16 05:55:46 PST ---
(In reply to comment #0)
> simple cleanup of unnecessary Rectangle allocation

Could you add a bit of detail? I wasn't able to understand if this was a task,
a bug report or a placeholder for a (currently missing) patch proposal. ;-)

>From the subject, as a file/class wasn't specified, a find-in-files showed that
this refers to "org.apache.batik.ext.awt.geom.RectListManager".

Please consider also adding a bit of background on what's going on, environment
details (such as the specific Batik revision, as the "1.8" is a bit ambiguous
as it doesn't yet correspond to an actual release, etc.).

Without further input I'd say it's hard (impossible?) to guess on your
intention. I'm marking the issue accordingly (to call for attention). ;-)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org


DO NOT REPLY [Bug 47202] [PATCH] Unnecessary allocation in RectListManager.mergeRects

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47202


Thomas Deweese <de...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Thomas Deweese <de...@apache.org>  2009-05-17 06:25:37 PST ---
Patch applied see Rev: 775642.
Thanks!

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org