[GitHub] [incubator-superset] michellethomas commented on pull request #9832: fix: Removing the logic to add timeseries_limit_metric to the data for table

[GitBox <gi...@apache.org>]

michellethomas commented on pull request #9832:
URL: https://github.com/apache/incubator-superset/pull/9832#issuecomment-631059907


   @john-bodley the unit test that's there should prevent the time series table column from showing up in the data that gets returned, it was just written originally to return it because that was needed for the frontend.
   
   I think this should have an integration test to make sure that when there's a metric and a sortby on a table, only the metric column shows up, that would have caught this bug when the table viz changed.  When I looked into this, I noticed that the visualization integration tests were not actually running. Are you ok if I add the test in a separate PR after the visualization tests are turned back on?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org